Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-11707

Require login for edit searches that need it rather than dropping predicates

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • Edit search
    • None

      Right now, a search like https://musicbrainz.org/search/edits?auto_edit_filter=&order=rand&negation=0&combinator=and&conditions.0.field=edit_note_author&conditions.0.operator=not_edit_author&conditions.0.name=&conditions.0.args.0=&conditions.1.field=edit_note_author&conditions.1.operator=!%3D&conditions.1.name=ModBot&conditions.1.args.0=4&conditions.2.field=edit_note_author&conditions.2.operator=not_me&conditions.2.name=&conditions.2.args.0=&conditions.3.field=voter&conditions.3.operator=me&conditions.3.name=&conditions.3.voter_id=&conditions.3.args=no&conditions.4.field=status&conditions.4.operator=!%3D&conditions.4.args=1&field=Please+choose+a+condition will just drop all the conditions that require login if opened when logged out, and turn into a "status: open" search. This is confusing, and it would be better to just tell the user that they need to log in to see the search. It also causes some Catalyst warnings, for what it's worth: 

       

      [warning] Unable to construct predicate from input (Attribute (user) does not pass the type constraint because: Validation failed for 'MusicBrainz::Server::Authentication::User' with value undef (not isa MusicBrainz::Server::Authentication::User) at /home/musicbrainz/carton-local/lib/perl5/x86_64-linux-gnu-thread-multi/Moose/Object.pm line 24 

            Unassigned Unassigned
            reosarevok Nicolás Tamargo
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package