Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-11946

WS tag submission with unescaped & gives an unexplained 500

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Normal Normal
    • None
    • None
    • Web service
    • None

      Unescaped ampersands are invalid XML, so the server should notice this and probably return bad request. Instead, it's just dying with an ISE.

      https://sentry.metabrainz.org/metabrainz/musicbrainz-server/issues/104536/?referrer=jira_plugin

      None: 
      not well-formed (invalid token) at line 5, column 144, byte 287:
        <release id="00c0942c-bfe8-41ba-95dd-d0a1d0d7291b">
         <user-tag-list>
          <user-tag><name>dancehall</name></user-tag><user-tag><name>dub</name></user-tag><user-tag><name>hip hop</name></user-tag><user-tag><name>r&b</name></user-tag><user-tag><name>reggae</name></user-tag><user-tag><name>soul</name></user-tag><user-tag><name>funk</name></user-tag><user-tag><name>ragga</name></user-tag>
      ===============================================================================================================================================^
         </user-tag-list>
        </release>
        File "Tag.pm", line 71, in Catalyst::detach
          for my $node ($xp->find('/mb:metadata/*/*')->get_nodelist)
        File "Tag.pm", line 55, in Catalyst::dispatch
          $c->detach('tag_submit') if $c->request->method eq 'POST';
        File "Server.pm", line 390, in MusicBrainz::Server::__ANON__
          $c->$orig(@args)
        File "Server.pm", line 357, in MusicBrainz::Server::with_translations
          $code->();
        File "Server.pm", line 391, in Class::MOP::Method::Wrapped::__ANON__
          });
      ...
      (2 additional frame(s) were not displayed)
      

            Unassigned Unassigned
            dev-sentry Dev through Sentry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package