Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-12412

Fail gracefully if requesting an invalid ID in edit-cover-art

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2022-06-07
    • None
    • Editing interface
    • None

      https://musicbrainz.org/release/c297dfbc-9474-4cd7-9c36-191c8e0898d7/edit-cover-art/undefined ISEs when trying to load the artwork types for the clearly non-existent artwork. This should fail gracefully before that.

      Sentry Issue: MUSICBRAINZ-SERVER-21

      None: Can't call method "types" on an undefined value at lib/MusicBrainz/Server/Controller/Release.pm line 613.
        File "Release.pm", line 613, in Catalyst::dispatch
          my @type_ids = map { $_->id } $c->model('CoverArtType')->get_by_name(@{ $artwork->types });
        File "Server.pm", line 388, in MusicBrainz::Server::__ANON__
          $c->$orig(@args)
        File "Server.pm", line 353, in MusicBrainz::Server::with_translations
          $code->();
        File "Server.pm", line 389, in Class::MOP::Method::Wrapped::__ANON__
          });
        File "Server.pm", line 403, in Class::MOP::Method::Wrapped::__ANON__
          $c->$orig(@args);
      ...
      (1 additional frame(s) were not displayed)
      

            reosarevok Nicolás Tamargo
            dev-sentry Dev through Sentry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2022-06-07