Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-12588

ISE in CDTOC->add_dash when passing "discid" with parens

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2023-02-28
    • None
    • CD support
    • None

      This seems unlikely to be triggered without passing crap to the add_dash method, but since clearly people do, we should escape the regex.

      Sentry Issue: MUSICBRAINZ-SERVER-26N

      None: Unmatched ) in regex; marked by <-- HERE in m/) <-- HERE ))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))/ at lib/MusicBrainz/Server/ControllerUtils/CDTOC.pm line 14.
        File "CDTOC.pm", line 14, in MusicBrainz::Server::ControllerUtils::CDTOC::add_dash
          my $redir = $c->relative_uri =~ s/$discid/$discid-/r;
        File "CDStub.pm", line 22, in MusicBrainz::Server::Controller::CDStub::_load
          add_dash($c, $id);
        File "Load.pm", line 67, in Catalyst::dispatch
          my $entity = $self->_load($c, @args);
        File "Server.pm", line 388, in MusicBrainz::Server::__ANON__
          $c->$orig(@args)
        File "Server.pm", line 353, in MusicBrainz::Server::with_translations
          $code->();
      ...
      (3 additional frame(s) were not displayed)
      

            reosarevok Nicolás Tamargo
            dev-sentry Dev through Sentry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2023-02-28