Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-12942

Indicate pending edits for an entity in the relationship editor

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2023-07-10
    • None
    • Relationship editor
    • None

      The old relationship editor indicated pending edits for entities (ones already pending by the time the user opened the relationship editor, that is) with an orange highlight. The new editor does not indicate these at all.

      Not showing the pending edits for the entities might be an intentional choice, but we might still want to show this state in some way. We show pending edits for the relationship in question with a warning sign that leads to a relevant edit search on hover (MBS-12941). We could do the same for pending edits for the entity, if we still feel indicating them in the editor is useful?

        1. image-2023-03-01-14-41-12-502.png
          image-2023-03-01-14-41-12-502.png
          11 kB
        2. image-2023-03-01-14-41-53-330.png
          image-2023-03-01-14-41-53-330.png
          12 kB
        3. image-2023-03-01-14-42-29-873.png
          image-2023-03-01-14-42-29-873.png
          12 kB
        4. image-2023-03-01-14-42-53-349.png
          image-2023-03-01-14-42-53-349.png
          12 kB
        5. image-2023-03-01-14-43-36-652.png
          image-2023-03-01-14-43-36-652.png
          11 kB
        6. image-2023-03-01-15-42-58-632.png
          image-2023-03-01-15-42-58-632.png
          14 kB
        7. image-2023-03-01-15-48-31-315.png
          image-2023-03-01-15-48-31-315.png
          11 kB
        8. image-2023-03-01-15-50-11-281.png
          image-2023-03-01-15-50-11-281.png
          11 kB
        9. image-2023-03-01-15-53-32-638.png
          image-2023-03-01-15-53-32-638.png
          11 kB
        10. image-2023-03-01-15-54-04-312.png
          image-2023-03-01-15-54-04-312.png
          11 kB
        11. image-2023-03-12-20-24-31-940.png
          image-2023-03-12-20-24-31-940.png
          25 kB
        12. image-2023-03-12-20-28-01-205.png
          image-2023-03-12-20-28-01-205.png
          11 kB
        13. image-2023-03-14-20-43-15-996.png
          image-2023-03-14-20-43-15-996.png
          4 kB
        14. image-2023-06-12-23-44-35-788.png
          image-2023-06-12-23-44-35-788.png
          0.6 kB
        15. image-2023-06-12-23-45-18-841.png
          image-2023-06-12-23-45-18-841.png
          0.6 kB
        16. image-2023-06-12-23-51-19-487.png
          image-2023-06-12-23-51-19-487.png
          1 kB
        17. openedit-entity.png
          openedit-entity.png
          1 kB
        18. openedit-entity.svg
          0.8 kB
        19. openedit-entity-02.png
          openedit-entity-02.png
          0.2 kB
        20. openedit-entity-02.svg
          0.8 kB
        21. openedit-relationship.png
          openedit-relationship.png
          1 kB
        22. openedit-relationship.svg
          1.0 kB
        23. openedit-relationship-02.png
          openedit-relationship-02.png
          0.3 kB
        24. openedit-relationship-02.svg
          1 kB

          [MBS-12942] Indicate pending edits for an entity in the relationship editor

          Aerozol added a comment - - edited

          New versions, 1:1 with the new icons at MBS-12951:

          openedit-entity-02.svg

          openedit-relationship-02.svg

          edit: ran icons through tiny png for bonus savings

          Aerozol added a comment - - edited New versions, 1:1 with the new icons at MBS-12951 : openedit-entity-02.svg openedit-relationship-02.svg edit: ran icons through tiny png for bonus savings

          I think the clock might be clearer about the "pending" concept, at least, so I'd probably go with that  

          Nicolás Tamargo added a comment - I think the clock might be clearer about the "pending" concept, at least, so I'd probably go with that  

          Aerozol added a comment -

          After feedback from atj (which I lost in my emails, sorry all...) I redid this icon for clarity:

          vs

          Thoughts?

          If people like this look we can do similar ones for our [ + ] [ x ] icons:

          Aerozol added a comment - After feedback from atj (which I lost in my emails, sorry all...) I redid this icon for clarity: vs Thoughts? If people like this look we can do similar ones for our [ + ] [ x ] icons:

          GitHub Bot added a comment -

          See code changes in pull request #2901 submitted by reosarevok.

          GitHub Bot added a comment - See code changes in pull request #2901 submitted by reosarevok .

          Aerozol added a comment -

          Correct!

          Attached in png and svg, let me know if you need something else:

           

          openedit-entity.svg

          openedit-relationship.svg

          Aerozol added a comment - Correct! Attached in png and svg, let me know if you need something else:   openedit-entity.svg openedit-relationship.svg

          I like it! So the idea is the left is for edits to the entity, the right for edits to the relationship?

          Nicolás Tamargo added a comment - I like it! So the idea is the left is for edits to the entity, the right for edits to the relationship?

          Aerozol added a comment -

          We can leave the different colours for now, just brainstorming.

          I've probably faffed with these icons enough for now... I think this is my final, if it looks okay to you:

          Blends in with the entity 'edit pending' highlight a bit, if we ever use it elsewhere, but not too much.

          Let me know if you'd like changes, otherwise I can supply it at different sizes.

          Aerozol added a comment - We can leave the different colours for now, just brainstorming. I've probably faffed with these icons enough for now... I think this is my final, if it looks okay to you: Blends in with the entity 'edit pending' highlight a bit, if we ever use it elsewhere, but not too much. Let me know if you'd like changes, otherwise I can supply it at different sizes.

          The main issue I can see is that a) there might be multiple edits to the same entity (some destructive, some not) and b) all we have right now is a number, the count of pending edits, but we have no idea about what the edits are.

          Nicolás Tamargo added a comment - The main issue I can see is that a) there might be multiple edits to the same entity (some destructive, some not) and b) all we have right now is a number, the count of pending edits, but we have no idea about what the edits are.

          Aerozol added a comment -

          re. different icons for different edits, what about highlighting if it's 'destructive' or minor, etc? Using Picard's three colour scheme (potentially drop the yellow and just use red and orange):

          There's been more icon discussion in the meantime so the icons above use the 'Fontawesome' icon set look that BookBrainz uses. I'll try align with this in general, in future.

          New look 'pencil' in-situ:

          Once we've decided how the icon will work, in general, and picked an icon, I'll do a second set for 'this relationship has open edits'.

          Feedback please!

          p.s. a wack idea, if we use an hourglass we should try change how full it is depending on how soon the edit is closing * gif of person holding their head and flying through stars and galaxies *

          Aerozol added a comment - re. different icons for different edits, what about highlighting if it's 'destructive' or minor, etc? Using Picard's three colour scheme (potentially drop the yellow and just use red and orange): There's been more icon discussion in the meantime so the icons above use the 'Fontawesome' icon set look that BookBrainz uses. I'll try align with this in general, in future. New look 'pencil' in-situ: Once we've decided how the icon will work, in general, and picked an icon, I'll do a second set for 'this relationship has open edits'. Feedback please! p.s. a wack idea, if we use an hourglass we should try change how full it is depending on how soon the edit is closing * gif of person holding their head and flying through stars and galaxies *

          UltimateRiff added a comment -

          I think having different icons to show what kind of edits are open might be nice, that way you could tell if it's a merge, deletion, or something else. I don't think we'd need an icon for every type of edit, just some of the big destructive ones at least.

          UltimateRiff added a comment - I think having different icons to show what kind of edits are open might be nice, that way you could tell if it's a merge, deletion, or something else. I don't think we'd need an icon for every type of edit, just some of the big destructive ones at least.

            reosarevok Nicolás Tamargo
            reosarevok Nicolás Tamargo
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2023-07-10