-
Bug
-
Resolution: Fixed
-
Normal
-
None
-
None
Trying to load https://beta.musicbrainz.org/edit/11760720 results in the following ISE:
Internal Server Error Oops, something went wrong! Error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at lib/MusicBrainz/Server/Renderer.pm line 47. at lib/MusicBrainz/Server/Renderer.pm line 47 MusicBrainz::Server::Renderer::send_to_renderer(?, ?, ?) called at lib/MusicBrainz/Server/Renderer.pm line 60 MusicBrainz::Server::Renderer::render_component(?, ?, ?) called at lib/MusicBrainz/Server/View/Node.pm line 20 Catalyst::dispatch(?) called at lib/MusicBrainz/Server.pm line 390 MusicBrainz::Server::__ANON__ at lib/MusicBrainz/Server.pm line 355 MusicBrainz::Server::with_translations(?, ?) called at lib/MusicBrainz/Server.pm line 391 Class::MOP::Method::Wrapped::__ANON__(?) called at lib/MusicBrainz/Server.pm line 405 Class::MOP::Method::Wrapped::__ANON__(?) called at lib/MusicBrainz/Server.pm line 493 Edits loaded for the page: 11760720 (raw edit data); fully loaded Time: 2023-03-15T08:33:34.747Z Host: d6787cf90c99 Interface language: en URL: https://beta.musicbrainz.org/edit/11760720
This seems to be an old bug, brought to light by https://github.com/metabrainz/musicbrainz-server/commit/268d6e51db045be90b3b2ec49d28190d2cfb1fe5
We are trying to access source_type for relationships and using that as the entity type in linkedEntities, but we were not actually setting a source_type on Edit::Historic::Relationship::_display_relationships, even though Entity::Relationship theoretically requires it (I keep getting the feeling that Moose types are fucking useless).
Not marking this as a beta bug as such because the bug was already there, it was just hidden.