Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-13751

Display addition/removal of no-op credits in edits

XMLWordPrintable

      When a relationship edit adds or removes a "credited as" name that's identical to the entity's name, the difference isn't displayed, making the edit look like it's a no-op.

      https://musicbrainz.org/edit/115462163 is an example of this:

      I'm not sure of the best way to fix this. I think that root/static/scripts/common/components/EntityLink.js typically just displays the credited-as name (content) in place of the entity name (entityName). If the names don't match, the entity name is included in the title attribute, but since they're the same here, that doesn't happen.

      It seems like it could be reasonable to include an extra " (as <credited-as>)" after the name in cases where credited-as has changed but the entity has remained the same, but detecting that would probably need to happen at a higher level like root/static/scripts/edit/components/edit/RelationshipDiff.js and then get passed through root/static/scripts/common/components/DescriptiveLink.js.

            derat derat
            derat derat
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2024-10-21