Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-1917

Delete release group logic differs from the checks required to enter the edit, and leads to unclosable edits

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • NGS - Final
    • None
    • Edit system
    • None

      ocharles>that's because it's filter the list of release groups to delete to ()
      ocharles>sub delete checks that release_groups are not in_use, but the edit checks that release_groups can_delete is true

      Summary was:

      This isn't all that important, but ModBot will remind us hourly of this bug, so it would be nice to fix it sooner.

      Could not accept 14459589: Failed query:
      '
      DELETE FROM l_artist_release_group a
      WHERE entity1 IN ()
      '
      ()
      DBD::Pg::st execute failed: ERROR: syntax error at or near ")"
      LINE 3: WHERE entity1 IN ()
      ^ at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 103.

      at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 109
      Sql::_ANON_('DBD::Pg::st execute failed: ERROR: syntax error at or near "...') called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 100
      Try::Tiny::try('CODE(0x71a87e8)', 'Try::Tiny::Catch=REF(0x71a9100)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 110
      Sql::do('Sql=HASH(0x6ae6508)', '\x

      {a} DELETE FROM l_artist_release_group a\x{a}

      ...') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Relationship.pm line 322
      MusicBrainz::Server::Data::Relationship::delete_entities('MusicBrainz::Server::Data::Relationship=HASH(0x6e60848)', 'release_group') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/ReleaseGroup.pm line 408
      MusicBrainz::Server::Data::ReleaseGroup::delete('MusicBrainz::Server::Data::ReleaseGroup=HASH(0x4497a78)', 1066691) called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Edit/Generic/Delete.pm line 115
      MusicBrainz::Server::Edit::Generic::Delete::_ANON_('MusicBrainz::Server::Edit::ReleaseGroup::Delete=HASH(0x71a0f78)') called at /usr/local/lib/perl/5.10.1/Moose/Meta/Method/Overridden.pm line 36
      MusicBrainz::Server::Edit::Generic::Delete::accept('MusicBrainz::Server::Edit::ReleaseGroup::Delete=HASH(0x71a0f78)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 520
      eval

      {...} called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 519
      MusicBrainz::Server::Data::Edit::_do_accept('MusicBrainz::Server::Data::Edit=HASH(0x3faaa58)', 'MusicBrainz::Server::Edit::ReleaseGroup::Delete=HASH(0x71a0f78)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 568
      MusicBrainz::Server::Data::Edit::_ANON_('MusicBrainz::Server::Edit::ReleaseGroup::Delete=HASH(0x71a0f78)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 599
      MusicBrainz::Server::Data::Edit::_close('MusicBrainz::Server::Data::Edit=HASH(0x3faaa58)', 'MusicBrainz::Server::Edit::ReleaseGroup::Delete=HASH(0x71a0f78)', 'CODE(0x71862d8)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/Data/Edit.pm line 568
      MusicBrainz::Server::Data::Edit::accept('MusicBrainz::Server::Data::Edit=HASH(0x3faaa58)', 'MusicBrainz::Server::Edit::ReleaseGroup::Delete=HASH(0x71a0f78)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 150
      MusicBrainz::Server::EditQueue::_process_open_edit('MusicBrainz::Server::EditQueue=HASH(0x3c878c0)', 'MusicBrainz::Server::Edit::ReleaseGroup::Delete=HASH(0x71a0f78)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 112
      MusicBrainz::Server::EditQueue::_process_edit('MusicBrainz::Server::EditQueue=HASH(0x3c878c0)', 14459589) called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 70
      MusicBrainz::Server::EditQueue::_ANON_() called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 262
      Sql::_ANON_() called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 76
      eval {...}

      called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 67
      Try::Tiny::try('CODE(0x715ccb0)', 'Try::Tiny::Catch=REF(0x7185cc0)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 275
      Sql::_auto_transaction('CODE(0x3e98ed8)', 'Sql=HASH(0x3c89e78)', 'Sql=HASH(0x3e10238)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 287
      Sql::_run_in_transaction_two('CODE(0x3e98ed8)', 'Sql=HASH(0x3c89e78)', 'Sql=HASH(0x3e10238)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 298
      Sql::run_in_transaction('CODE(0x3e98ed8)', 'Sql=HASH(0x3c89e78)', 'Sql=HASH(0x3e10238)') called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 71
      eval

      {...}

      called at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 68
      MusicBrainz::Server::EditQueue::process_edits('MusicBrainz::Server::EditQueue=HASH(0x3c878c0)') called at ./admin/CheckVotes.pl line 54
      at /home/musicbrainz/musicbrainz-server/admin/../lib/MusicBrainz/Server/EditQueue.pm line 150
      Error while processing edit #14459589: Failed query:
      'UPDATE release_group SET edits_pending = edits_pending + ? WHERE id IN '
      (-1 1066691)
      DBD::Pg::st execute failed: ERROR: current transaction is aborted, commands ignored until end of transaction block at /home/musicbrainz/musicbrainz-server/admin/../lib/Sql.pm line 103.

            acid2 Oliver Charles
            rob Robert Kaye
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                NGS - Final