-
Bug
-
Resolution: Duplicate
-
High
-
None
-
None
-
None
Background:
A set of recordings needed splitting to distinguish between the original mixes and recent remasters. I tried to do this by using the release editor on the remaster release, and selecting "Add new recording" on the recordings tab for each track. This created edits the edit medium edits, #15061290 and #15061291. These edits don't show links to the new recordings (and it appears that no recordings were actually created). When the edit was approved, it failed with a status of "Failed dependency"
Analysis:
I've been unable to reproduce this behaviour entirely on the test server. An edit medium edit that creates recordings still doesn't link to the new recordings, but does now succeed when approved, and the medium does get updated appropriately.
I suspect that that may be because this bug has been partially fixed there (though I've been unable to find a ticket describing this), and all that remains is to fix the edit medium edits to link to the new recordings correctly, as per the bug summary. However, it may just be that something odd happened with the above two edits. If this is the case, then this needs investigating specifically, and an additional ticket may need creating.
[MBS-3307] Edit medium edits that add new recordings don't link to those recordings
Found related issue via http://blog.musicbrainz.org/?p=1042. Oddly, the part of this problem that the linked issue describes as fixed is the only part of the problem that was recreateable on test.musicbrainz.org.
Raised priority given concerns about possible database corruption.
I tried a few times to recreate edits #15061290 and #15061291, but it now fails consistently with an internal server error:
Internal Server Error
Oops, something went wrong!
Error:
Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Edit->edit "Failed query:
'INSERT INTO edit_note (editor,text,edit) VALUES (?,?,?)'
(4 This edit changes recording IDs, but some of the recordings no longer exist. 15064978)
DBD::Pg::st execute failed: ERROR: insert or update on table "edit_note" violates foreign key constraint "edit_note_fk_edit"
DETAIL: Key (edit)=(15064978) is not present in table "edit". at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 103.
at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 109
Sql::_ANON_('DBD::Pg::st execute failed: ERROR: insert or update on table...') called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 100
Try::Tiny::try('CODE(0xd3a25d0)', 'Try::Tiny::Catch=REF(0xec38ac0)') called at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 110
Sql::do('Sql=HASH(0xb485ad0)', 'INSERT INTO edit_note (editor,text,edit) VALUES (?,?,?)', 4, 'This edit changes recording IDs, but some of the recordings n...', 15064978) called at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 149
Sql::insert_row('Sql=HASH(0xb485ad0)', 'edit_note', 'HASH(0xa26e4b8)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Data/EditNote.pm line 69
MusicBrainz::Server::Data::EditNote::insert('MusicBrainz::Server::Data::EditNote=HASH(0xec987b8)', 15064978, 'HASH(0x80aa100)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Data/EditNote.pm line 75
MusicBrainz::Server::Data::EditNote::add_note('MusicBrainz::Server::Data::EditNote=HASH(0xec987b8)', 15064978, 'HASH(0x80aa100)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Data/Edit.pm line 527
MusicBrainz::Server::Data::Edit::_do_accept('MusicBrainz::Server::Data::Edit=HASH(0x9a66970)', 'MusicBrainz::Server::Edit::Medium::Edit=HASH(0xd27e300)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Data/Edit.pm line 409
MusicBrainz::Server::Data::Edit::_ANON_() called at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 264
Sql::_ANON_() called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 76
eval
Try::Tiny::try('CODE(0xec69218)', 'Try::Tiny::Catch=REF(0xec7a2f0)') called at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 277
Sql::_auto_transaction('CODE(0xec38898)', 'Sql=HASH(0xb485ad0)') called at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 282
Sql::_run_in_transaction_one('CODE(0xec38898)', 'Sql=HASH(0xb485ad0)') called at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 296
Sql::run_in_transaction('CODE(0xec38898)', 'Sql=HASH(0xb485ad0)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Data/Edit.pm line 443
MusicBrainz::Server::Data::Edit::create('MusicBrainz::Server::Data::Edit=HASH(0x9a66970)', 'edit_type', 52, 'editor_id', 304189, 'format_id', 1, 'privileges', 0, ...) called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 1183
MusicBrainz::Server::Wizard::ReleaseEditor::_ANON_('edit_type', 52, 'editor_id', 304189, 'format_id', 1, 'privileges', 0, 'separate_tracklists', ...) called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 1208
eval {...}
called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 1207
MusicBrainz::Server::Wizard::ReleaseEditor::_create_edit('MusicBrainz::Server::Wizard::ReleaseEditor::Edit=HASH(0xd21a738)', 'CODE(0xec68d80)', 52, 304189, 'privileges', 0, 'format_id', 1, 'separate_tracklists', ...) called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 1184
MusicBrainz::Server::Wizard::ReleaseEditor::_submit_edit('MusicBrainz::Server::Wizard::ReleaseEditor::Edit=HASH(0xd21a738)', 52, 'Retrying edit #15061290, edit #15061291.', 'format_id', 1, 'separate_tracklists', 1, 'name', 'Mono', ...) called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 776
MusicBrainz::Server::Wizard::ReleaseEditor::_ANON_(52, 'Retrying edit #15061290, edit #15061291.', 'format_id', 1, 'separate_tracklists', 1, 'name', 'Mono', 'tracklist', ...) called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 1065
MusicBrainz::Server::Wizard::ReleaseEditor::_edit_release_track_edits('MusicBrainz::Server::Wizard::ReleaseEditor::Edit=HASH(0xd21a738)', 'edit_note', 'Retrying edit #15061290, edit #15061291.', 'data', 'HASH(0xd2fa3c0)', 'create_edit', 'CODE(0xcd1f758)', 'previewing', '', ...) called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 869
MusicBrainz::Server::Wizard::ReleaseEditor::create_common_edits('MusicBrainz::Server::Wizard::ReleaseEditor::Edit=HASH(0xd21a738)', 'edit_note', 'Retrying edit #15061290, edit #15061291.', 'data', 'HASH(0xd2fa3c0)', 'create_edit', 'CODE(0xcd1f758)', 'previewing', '', ...) called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 849
MusicBrainz::Server::Wizard::ReleaseEditor::create_edits('MusicBrainz::Server::Wizard::ReleaseEditor::Edit=HASH(0xd21a738)', 'data', 'HASH(0xd2fa3c0)', 'create_edit', 'CODE(0xcd1f758)', 'edit_note', 'Retrying edit #15061290, edit #15061291.', 'previewing', '', ...) called at /usr/local/lib/perl/5.10.1/Moose/Meta/Method/Augmented.pm line 46
MusicBrainz::Server::Wizard::ReleaseEditor::Edit::create_edits('MusicBrainz::Server::Wizard::ReleaseEditor::Edit=HASH(0xd21a738)', 'data', 'HASH(0xd2fa3c0)', 'create_edit', 'CODE(0xcd1f758)', 'edit_note', 'Retrying edit #15061290, edit #15061291.', 'previewing', '', ...) called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 777
MusicBrainz::Server::Wizard::ReleaseEditor::prepare_edits('MusicBrainz::Server::Wizard::ReleaseEditor::Edit=HASH(0xd21a738)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 93
MusicBrainz::Server::Wizard::ReleaseEditor::run('MusicBrainz::Server::Wizard::ReleaseEditor::Edit=HASH(0xd21a738)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Controller/ReleaseEditor/Edit.pm line 17
MusicBrainz::Server::Controller::ReleaseEditor::Edit::edit('MusicBrainz::Server::Controller::ReleaseEditor::Edit=HASH(0xa...', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 65
Catalyst::Action::execute('Catalyst::Action=HASH(0xae5c820)', 'MusicBrainz::Server::Controller::ReleaseEditor::Edit=HASH(0xa...', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
eval
Catalyst::execute('MusicBrainz::Server=HASH(0xd2ed3a8)', 'MusicBrainz::Server::Controller::ReleaseEditor::Edit', 'Catalyst::Action=HASH(0xae5c820)') called at /usr/local/share/perl/5.10.1/Catalyst/Plugin/StackTrace.pm line 94
Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xd2ed3a8)', 'MusicBrainz::Server::Controller::ReleaseEditor::Edit', 'Catalyst::Action=HASH(0xae5c820)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 60
Catalyst::Action::dispatch('Catalyst::Action=HASH(0xae5c820)', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst/ActionChain.pm line 39
Catalyst::ActionChain::dispatch('Catalyst::ActionChain=HASH(0xcb6ab70)', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst/Controller.pm line 110
Catalyst::Controller::_ACTION('MusicBrainz::Server::Controller::ReleaseEditor::Add=HASH(0xac...', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 65
Catalyst::Action::execute('Catalyst::Action=HASH(0xae4e730)', 'MusicBrainz::Server::Controller::ReleaseEditor::Add=HASH(0xac...', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
eval {...}
called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
Catalyst::execute('MusicBrainz::Server=HASH(0xd2ed3a8)', 'MusicBrainz::Server::Controller::ReleaseEditor::Add', 'Catalyst::Action=HASH(0xae4e730)') called at /usr/local/share/perl/5.10.1/Catalyst/Plugin/StackTrace.pm line 94
Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xd2ed3a8)', 'MusicBrainz::Server::Controller::ReleaseEditor::Add', 'Catalyst::Action=HASH(0xae4e730)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 60
Catalyst::Action::dispatch('Catalyst::Action=HASH(0xae4e730)', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 257
Catalyst::Dispatcher::_do_forward('Catalyst::Dispatcher=HASH(0x350b9c0)', 'forward', 'MusicBrainz::Server=HASH(0xd2ed3a8)', '_ACTION') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 237
Catalyst::Dispatcher::forward('Catalyst::Dispatcher=HASH(0x350b9c0)', 'MusicBrainz::Server=HASH(0xd2ed3a8)', '_ACTION') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 377
Catalyst::forward('MusicBrainz::Server=HASH(0xd2ed3a8)', '_ACTION') called at /usr/local/share/perl/5.10.1/Catalyst/Controller.pm line 84
Catalyst::Controller::_DISPATCH('MusicBrainz::Server::Controller::ReleaseEditor::Add=HASH(0xac...', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 65
Catalyst::Action::execute('Catalyst::Action=HASH(0xaf703e8)', 'MusicBrainz::Server::Controller::ReleaseEditor::Add=HASH(0xac...', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
eval
Catalyst::execute('MusicBrainz::Server=HASH(0xd2ed3a8)', 'MusicBrainz::Server::Controller::ReleaseEditor::Add', 'Catalyst::Action=HASH(0xaf703e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Plugin/StackTrace.pm line 94
Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xd2ed3a8)', 'MusicBrainz::Server::Controller::ReleaseEditor::Add', 'Catalyst::Action=HASH(0xaf703e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 60
Catalyst::Action::dispatch('Catalyst::Action=HASH(0xaf703e8)', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 257
Catalyst::Dispatcher::_do_forward('Catalyst::Dispatcher=HASH(0x350b9c0)', 'forward', 'MusicBrainz::Server=HASH(0xd2ed3a8)', '/release_editor/_DISPATCH') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 237
Catalyst::Dispatcher::forward('Catalyst::Dispatcher=HASH(0x350b9c0)', 'MusicBrainz::Server=HASH(0xd2ed3a8)', '/release_editor/_DISPATCH') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 377
Catalyst::forward('MusicBrainz::Server=HASH(0xd2ed3a8)', '/release_editor/_DISPATCH') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 105
Catalyst::Dispatcher::dispatch('Catalyst::Dispatcher=HASH(0x350b9c0)', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1611
Catalyst::dispatch('MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst/Plugin/Static/Simple.pm line 76
Class::MOP::Class:::around('CODE(0x3b6a530)', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/lib/perl/5.10.1/Class/MOP/Method/Wrapped.pm line 159
Class::MOP::Method::Wrapped::_ANON_('MusicBrainz::Server=HASH(0xd2ed3a8)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server.pm line 270
Class::MOP::Class:::around('CODE(0xb1d1688)', 'MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/lib/perl/5.10.1/Class/MOP/Method/Wrapped.pm line 159
Class::MOP::Method::Wrapped::_ANON_('MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/lib/perl/5.10.1/Class/MOP/Method/Wrapped.pm line 89
MusicBrainz::Server::dispatch('MusicBrainz::Server=HASH(0xd2ed3a8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1952
eval {...}
called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1943
Catalyst::handle_request('MusicBrainz::Server', 'env', 'HASH(0x48c64b0)') called at /home/musicbrainz/musicbrainz-server/script/../lib/Catalyst/Plugin/AutoRestart.pm line 119
Catalyst::Plugin::AutoRestart::handle_request('MusicBrainz::Server', 'env', 'HASH(0x48c64b0)') called at /usr/local/share/perl/5.10.1/Catalyst/Engine/FastCGI.pm line 149
Catalyst::Engine::FastCGI::run('Catalyst::Engine::FastCGI=HASH(0x4890060)', 'MusicBrainz::Server', '127.0.0.1:55901', 'HASH(0x23f7d48)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 2396
Catalyst::run('MusicBrainz::Server', '127.0.0.1:55901', 'HASH(0x23f7d48)') called at ./script/musicbrainz_fastcgi.pl line 28
at /home/musicbrainz/musicbrainz-server/script/../lib/Sql.pm line 277
...propagated at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard/ReleaseEditor.pm line 1217."
Stack trace:
line 1217 MusicBrainz::Server::Wizard::ReleaseEditor
line 1184 MusicBrainz::Server::Wizard::ReleaseEditor
line 776 MusicBrainz::Server::Wizard::ReleaseEditor
line 1065 MusicBrainz::Server::Wizard::ReleaseEditor
line 869 MusicBrainz::Server::Wizard::ReleaseEditor
line 849 MusicBrainz::Server::Wizard::ReleaseEditor
line 777 MusicBrainz::Server::Wizard::ReleaseEditor
line 93 MusicBrainz::Server::Wizard::ReleaseEditor
line 17 MusicBrainz::Server::Controller::ReleaseEditor::Edit
line 270 MusicBrainz::Server
Request data:
$VAR1 = {
'query_parameters' => {},
'body_parameters' =>
};
URL: http://musicbrainz.org/release/3a4c498b-1b30-3ac8-86a4-c42fe5a72365/edit
I believe this is the same issue. We should be shipping this out to production real soon now (tm)