Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-3427

"Internal Server Error" submitting CD Stubs with invalid data

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2013-06-24
    • Component/s: CD support
    • Labels:
      None

      Description

      When submitting a form missing some required fields, an "Internal Server Error" page appears to the end user. Error message follows below:

       
      Internal Server Error
      
      Oops, something went wrong!
      
      Error:
      
      Cannot add a CD stub with no tracks
      
      Trace begun at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Data/Utils.pm line 415
      MusicBrainz::Server::Data::Utils::check_data('HASH(0xbf746c0)', 'No title provided', 
      'CODE(0x863b338)', 'No artist names provided', 
      'CODE(0xbf75038)', 'Not all tracks specify an artist', 
      'CODE(0xbf747f8)', 'Not all tracks have a title', 
      'CODE(0xbf74e28)', 'Cannot add a CD stub with no tracks', 
      'CODE(0xbf74f90)', 'Incomplete TOC data', 
      'CODE(0xbf752f0)', 'Missing disc ID', 
      'CODE(0x863bba8)', 'Disc ID does match parsed TOC', 
      'CODE(0xbf75518)', 'Number of submitted tracks does not match track count in TOC', 
      'CODE(0xbefd7f8)', 'Invalid barcode', 
      'CODE(0x8641c08)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Data/CDStub.pm line 134
      MusicBrainz::Server::Data::CDStub::insert('MusicBrainz::Server::Data::CDStub=HASH(0x8601ae8)', 'HASH(0xbf746c0)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Controller/CDStub.pm line 77
      MusicBrainz::Server::Controller::CDStub::add('MusicBrainz::Server::Controller::CDStub=HASH(0x99c93c0)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 65
      Catalyst::Action::execute('Catalyst::Action=HASH(0x9df39b0)', 'MusicBrainz::Server::Controller::CDStub=HASH(0x99c93c0)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
      eval {...} at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
      Catalyst::execute('MusicBrainz::Server=HASH(0xbbf49e8)', 'MusicBrainz::Server::Controller::CDStub', 'Catalyst::Action=HASH(0x9df39b0)') called at /usr/local/share/perl/5.10.1/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xbbf49e8)', 'MusicBrainz::Server::Controller::CDStub', 'Catalyst::Action=HASH(0x9df39b0)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch('Catalyst::Action=HASH(0x9df39b0)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Controller.pm line 110
      Catalyst::Controller::_ACTION('MusicBrainz::Server::Controller::CDStub=HASH(0x99c93c0)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 65
      Catalyst::Action::execute('Catalyst::Action=HASH(0x9df6f90)', 'MusicBrainz::Server::Controller::CDStub=HASH(0x99c93c0)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
      eval {...} at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
      Catalyst::execute('MusicBrainz::Server=HASH(0xbbf49e8)', 'MusicBrainz::Server::Controller::CDStub', 'Catalyst::Action=HASH(0x9df6f90)') called at /usr/local/share/perl/5.10.1/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xbbf49e8)', 'MusicBrainz::Server::Controller::CDStub', 'Catalyst::Action=HASH(0x9df6f90)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch('Catalyst::Action=HASH(0x9df6f90)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward('Catalyst::Dispatcher=HASH(0x2248940)', 'forward', 'MusicBrainz::Server=HASH(0xbbf49e8)', '_ACTION') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward('Catalyst::Dispatcher=HASH(0x2248940)', 'MusicBrainz::Server=HASH(0xbbf49e8)', '_ACTION') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 377
      Catalyst::forward('MusicBrainz::Server=HASH(0xbbf49e8)', '_ACTION') called at /usr/local/share/perl/5.10.1/Catalyst/Controller.pm line 84
      Catalyst::Controller::_DISPATCH('MusicBrainz::Server::Controller::CDStub=HASH(0x99c93c0)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 65
      Catalyst::Action::execute('Catalyst::Action=HASH(0x9df3428)', 'MusicBrainz::Server::Controller::CDStub=HASH(0x99c93c0)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
      eval {...} at /usr/local/share/perl/5.10.1/Catalyst.pm line 1665
      Catalyst::execute('MusicBrainz::Server=HASH(0xbbf49e8)', 'MusicBrainz::Server::Controller::CDStub', 'Catalyst::Action=HASH(0x9df3428)') called at /usr/local/share/perl/5.10.1/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xbbf49e8)', 'MusicBrainz::Server::Controller::CDStub', 'Catalyst::Action=HASH(0x9df3428)') called at /usr/local/share/perl/5.10.1/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch('Catalyst::Action=HASH(0x9df3428)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward('Catalyst::Dispatcher=HASH(0x2248940)', 'forward', 'MusicBrainz::Server=HASH(0xbbf49e8)', '/cdstub/_DISPATCH') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward('Catalyst::Dispatcher=HASH(0x2248940)', 'MusicBrainz::Server=HASH(0xbbf49e8)', '/cdstub/_DISPATCH') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 377
      Catalyst::forward('MusicBrainz::Server=HASH(0xbbf49e8)', '/cdstub/_DISPATCH') called at /usr/local/share/perl/5.10.1/Catalyst/Dispatcher.pm line 105
      Catalyst::Dispatcher::dispatch('Catalyst::Dispatcher=HASH(0x2248940)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1611
      Catalyst::dispatch('MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst/Plugin/Static/Simple.pm line 76
      Class::MOP::Class:::around('CODE(0x28a7220)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/lib/perl/5.10.1/Class/MOP/Method/Wrapped.pm line 159
      Class::MOP::Method::Wrapped::__ANON__('MusicBrainz::Server=HASH(0xbbf49e8)') called at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server.pm line 270
      Class::MOP::Class:::around('CODE(0x9f2f130)', 'MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/lib/perl/5.10.1/Class/MOP/Method/Wrapped.pm line 159
      Class::MOP::Method::Wrapped::__ANON__('MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/lib/perl/5.10.1/Class/MOP/Method/Wrapped.pm line 89
      MusicBrainz::Server::dispatch('MusicBrainz::Server=HASH(0xbbf49e8)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 1952
      eval {...} at /usr/local/share/perl/5.10.1/Catalyst.pm line 1943
      Catalyst::handle_request('MusicBrainz::Server', 'env', 'HASH(0x3623000)') called at /home/musicbrainz/musicbrainz-server/script/../lib/Catalyst/Plugin/AutoRestart.pm line 119
      Catalyst::Plugin::AutoRestart::handle_request('MusicBrainz::Server', 'env', 'HASH(0x3623000)') called at /usr/local/share/perl/5.10.1/Catalyst/Engine/FastCGI.pm line 149
      Catalyst::Engine::FastCGI::run('Catalyst::Engine::FastCGI=HASH(0x35ecbd0)', 'MusicBrainz::Server', '127.0.0.1:55901', 'HASH(0x1134d48)') called at /usr/local/share/perl/5.10.1/Catalyst.pm line 2396
      Catalyst::run('MusicBrainz::Server', '127.0.0.1:55901', 'HASH(0x1134d48)') called at script/musicbrainz_fastcgi.pl line 28
      
      Stack trace:
      
          * line 415 MusicBrainz::Server::Data::Utils
          * line 134 MusicBrainz::Server::Data::CDStub
          * line 77 MusicBrainz::Server::Controller::CDStub
          * line 270 MusicBrainz::Server
      
      Request data:
      
      $VAR1 = {
                'query_parameters' => {
                                        'toc' => '1 21 283269 150 13054 26708 40511 54014 67368 80871 94525 108179 122133 136236 149439 162492 174645 189649 203152 217554 230757 244860 257013 271267'
                                      },
                'body_parameters' => {
                                       'CDStub.tracks.19.title' => '',
                                       'CDStub.title' => 'Complete Blue Note Recording',
                                       'CDStub.tracks.14.artist' => '',
                                       'CDStub.tracks.18.title' => '',
                                       'CDStub.barcode' => '',
                                       'CDStub.tracks.15.title' => '',
                                       'CDStub.tracks.8.title' => '',
                                       'CDStub.tracks.6.artist' => '',
                                       'CDStub.tracks.0.title' => '',
                                       'CDStub.tracks.1.title' => '',
                                       'CDStub.tracks.20.title' => '',
                                       'CDStub.tracks.13.artist' => '',
                                       'CDStub.tracks.11.title' => '',
                                       'CDStub.tracks.8.artist' => '',
                                       'CDStub.tracks.15.artist' => '',
                                       'CDStub.tracks.17.artist' => '',
                                       'CDStub.tracks.12.title' => '',
                                       'CDStub.artist' => 'Thelonius Monk ',
                                       'CDStub.tracks.7.artist' => '',
                                       'CDStub.tracks.16.title' => '',
                                       'CDStub.tracks.11.artist' => '',
                                       'CDStub.tracks.6.title' => '',
                                       'CDStub.tracks.0.artist' => '',
                                       'CDStub.tracks.14.title' => '',
                                       'CDStub.tracks.9.artist' => '',
                                       'CDStub.tracks.3.title' => '',
                                       'CDStub.tracks.5.title' => '',
                                       'CDStub.tracks.3.artist' => '',
                                       'CDStub.tracks.20.artist' => '',
                                       'CDStub.tracks.5.artist' => '',
                                       'CDStub.tracks.19.artist' => '',
                                       'CDStub.tracks.7.title' => '',
                                       'CDStub.tracks.10.artist' => '',
                                       'CDStub.tracks.10.title' => '',
                                       'CDStub.tracks.18.artist' => '',
                                       'CDStub.tracks.16.artist' => '',
                                       'CDStub.tracks.2.title' => '',
                                       'CDStub.tracks.17.title' => '',
                                       'CDStub.tracks.4.title' => '',
                                       'CDStub.tracks.9.title' => '',
                                       'CDStub.tracks.2.artist' => '',
                                       'CDStub.comment' => '',
                                       'CDStub.tracks.1.artist' => '',
                                       'CDStub.tracks.13.title' => '',
                                       'CDStub.tracks.12.artist' => '',
                                       'CDStub.tracks.4.artist' => ''
                                     }
              };
                  
      
      URL: http://musicbrainz.org/cdstub/add?toc=1+21+283269+150+13054+26708+40511+54014+67368+80871+94525+108179+122133+136236+149439+162492+174645+189649+203152+217554+230757+244860+257013+271267 
      

        Attachments

          Activity

            People

            • Assignee:
              ianmcorvidae Ian McEwen
              Reporter:
              Anonymous
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                2013-06-24