Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-3719

Format/display of recording search results is broken for standalone recordings

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: Bug fixes, 2011-10-10
    • Fix Version/s: Bug fixes, 2011-11-14
    • Component/s: Search
    • Labels:
      None

      Description

      e.g http://musicbrainz.org/search?query=artist%3A%22Nine+inch+Nails%22+trance+remix&type=recording&limit=25&advanced=1&tport=8000

      Based on
      https://github.com/metabrainz/musicbrainz-server/blob/master/root/search/lib/inline-results-recording.tt

      1. The alternating line colours don't work correctly.
      2. The colspan for (standalone recording) doesn't adjust correctly for the presence of the tagger link.
      3. Related to 2, no tagger link is displayed for the standalone recording. Once MBS-3689 is fixed, the standalone recording links should be the only lines that create opennat? style links.

      At a glance, to fix these, the colspan should probably be removed from the (standalone recording) TD and it changed to something like

                    <td>[% l('(standalone recording)') %]</td>
                    [%- IF c.session.tport -%]
                      <td>[% tagger_icon(result.entity) %]</td>
                    [%- END -%]
                    <td colspan="3">&nbsp;</td>
                    [%- linenum = linenum + 1 -%]
      

      The above also removes the centre alignment of the text; it looks really weird with a wide screen; and won't really work with the presence of the tagger icon.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                voiceinsideyou voiceinsideyou
                Reporter:
                voiceinsideyou voiceinsideyou
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Packages

                  Version Package
                  Bug fixes, 2011-11-14