Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-4359

Remove bogus parameter "name" and display actual entity name in edit search

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Low
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Edit search
    • Labels:
      None

      Description

      I simplify the ticket to more easily understandable « Remove bogus parameter "name" and display actual entity name in edit search » :

      Putting garbage in the parameter works, blanking it works too (same as removing it completely now).
      So this unused name parameter should be removed and the search form should simply display actual entity names.
      Only entity ID should be left in the URL (and even better MBID : MBS-4897).

      I keep below description for background information.


      Hello,

      MAIN BUG

      The URL for the edit search contains the bogus parameter "name".
      This parameter is (hopefully) not used for the request, the ID is there for that.
      When we replace the "name" parameter's value with any dummy string, the result is not changed but the display becomes wrong.

      NEW ! It can be used for insulting purpose ! (or phishing)
      Edits on RG "LOL" by editor TROUDUC (is actually getting results of an RG not called "LOL" by the serious editor ModBot).

      Example with only one criteria : 演唱會 (475 chars URL = 157 useful + 318 bogus) → LOL=演唱會.

      • repeated &conditions.0.name=%E6%BC%94%E5%94%B1%E6%9C%83%EF%BC%88%E4%B8%80%E4%B9%9D%E5%85%AB%E4%BA%8C%E5%B9%B4%E4%B8%80%E6%9C%88%E4%B9%9D%E3%80%81%E5%8D%81%E3%80%81%E5%8D%81%E4%B8%80%E6%97%A5%EF%BC%89%E7%8F%BE%E5%A0%B4%E9%8C%84%E9%9F%B3%E7%8F%8D%E8%97%8F%E7%89%88
      • repeated &conditions.0.=
      • once only &auto_edit_filter=&field=Please+choose+a+condition
      • and other empty parameters maybe specific to other criteria types

      Removing at least "name" parameter would be 1. nice for our URL fanciness 2. nice for scripting MB without having to display LOL texts.
      Removing the other empty/bogus parameters could be 1. even more fancy.

      SECONDARY BUG (updated 2012-11-02)

      I was in this page (Salyu).
      I wanted the same search with another artist so I typed :
      sherbets then ENTER KEY (too quickly because I'm faster than sound).
      I ended up on this page (Salyu as sherbets) ☜ I didn't trick the URL (this time), it's true, I swear, try ut !

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                chirlu Ulrich Klauer
                Reporter:
                jesus2099 jesus2099
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Packages

                  Version Package