Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-4621

Don't use empty <img> tags on pages with no images

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Bug fixes, 2012-05-28
    • Component/s: None
    • Labels:
      None

      Description

      http://caa.mbsandbox.org/release/e00b9eca-3f69-4757-b59a-f61779069482 has no cover art at all. Despite that, the page loads with an inital empty <img> tag which means that anyone with JS turned off sees a broken image when no image should be shown at all. Everyone else briefly sees a broken image until the JS has checked that there is (still) no cover art and removes it.

      Since we already keep track of whether a release has cover art or not, I can't see any point to doing it this way. When we know there is no cover art for a release, we should just output the "no cover art" message in the first place. It would also make the page rendering a lot smoother, right now the broken image being replaced by text is rather distracting to me.

        Attachments

          Activity

            People

            • Assignee:
              warp Kuno Woudt
              Reporter:
              nikki nikki
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                Bug fixes, 2012-05-28