Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-4949

Facebook URLs not properly decoded

    XMLWordPrintable

    Details

      Description

      See for example http://musicbrainz.org/artist/266d1014-7175-417e-9d39-554b7465073e

      Sorry, I don't have a dev VM set up, so I can't commit the fix, but here is the diff:

       
      diff --git a/lib/MusicBrainz/Server/Entity/URL/Facebook.pm b/lib/MusicBrainz/Server/Entity/URL/Facebook.pm
      index 4f2b52a..af3c23b 100644
      --- a/lib/MusicBrainz/Server/Entity/URL/Facebook.pm
      +++ b/lib/MusicBrainz/Server/Entity/URL/Facebook.pm
      @@ -1,6 +1,7 @@
       package MusicBrainz::Server::Entity::URL::Facebook;
       
       use Moose;
      +use MusicBrainz::Server::Filters;
       
       extends 'MusicBrainz::Server::Entity::URL';
       with 'MusicBrainz::Server::Entity::URL::Sidebar';
      @@ -9,7 +10,7 @@ sub sidebar_name {
           my $self = shift;
       
           if ($self->url =~ m{^https?://(?:www.)?facebook.com/(?:pages/)?([^/]+)(?:/[^/]+)?/?$}i) {
      -        return $1;
      +        return MusicBrainz::Server::Filters::uri_decode($1);
           } else {
               return "Facebook";
           }
      

        Attachments

          Activity

            People

            • Assignee:
              lukas Lukáš Lalinský
              Reporter:
              lukas Lukáš Lalinský
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                Bug fixes, 2012-07-23