Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-6485

Blocking of /ws/1 URLs should be done in MusicBrainz-Server, not nginx config

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2013-07-08
    • Component/s: None
    • Labels:
      None

      Description

      The nginx config we are currently running includes:

      	# Some artists we decline to list their releases - there are just too many.
      	# 89ad4ac3-39f7-470e-963a-56509c546377 = Various Artists
      	# b972f589-fb0e-474e-b64a-803b0364fa75 = Mozart
      	location ~ ^/ws/1/artist/(89ad4ac3-39f7-470e-963a-56509c546377|b972f589-fb0e-474e-b64a-803b0364fa75)$ {
      		set $method_and_args "$request_method $args";
      		if ($method_and_args ~* "^GET (&?(type=xml|inc=(\+*(aliases|(artist|label|release|track|url)-rels|tags|ratings|user-tags|user-ratings|counts|labels))*)?)*$") {
      			proxy_pass http://ngs;
      			break;
      		}
      		return 403;
      	}
      

      But this doesn't prevent trying to load these URLs with different MBIDs, such as http://musicbrainz.org/ws/1/artist/ae05b71d-f95d-41b2-82bf-6cabcc23fa59?inc=sa-Official.

      This is putting unnecessary strain on Totoro, who is frequently trying to respond to queries with 100k release groups.

        Attachments

          Activity

            People

            • Assignee:
              acid2 Oliver Charles
              Reporter:
              acid2 Oliver Charles
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                2013-07-08