-
Task
-
Resolution: Fixed
-
Normal
-
None
-
None
There are a number of places in the code where we have a list of entities. That means when things change, we have to update a lot of places, inevitably miss some and then we have bugs.
Fixing this is a bit complicated, since the list tends to vary depending on what exactly should be included and how "release group" should be written, but presumably something like a hash of data in the constants file with some functions for returning a matching list would work.
The ones I've found so far:
things with annotations
things with MBIDs
things with ratings
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Data/Editor.pm?at=beta#cl-116
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Data/Editor.pm?at=beta#cl-522
things with tags
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Data/Editor.pm?at=beta#cl-141
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Data/Editor.pm?at=beta#cl-513
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Controller/Tag.pm?at=beta#cl-49 (and possibly the subs below that)
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Controller/User.pm?at=beta#cl-426
things with subscriptions
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Data/Editor.pm?at=beta#cl-453
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Data/Editor.pm?at=beta#cl-554
- https://bitbucket.org/metabrainz/musicbrainz-server/src/eee20fd5b77b49966f0c4103174df36f1463b2ca/lib/MusicBrainz/Server/Data/Edit.pm?at=beta#cl-273 (except editor)
core entities