Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-7608

Internal server error looking up CD TOC with too large offsets

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2014-06-09
    • Component/s: Web service
    • Labels:
      None

      Description

      I'm guessing it's not a valid TOC, in which case we should reject it, not crash.

      https://beta.musicbrainz.org/ws/2/discid/SFqeTSCDwsqEAiS8N9qtY.E_pig-?inc=recordings+artist-credits&cdstubs=no&toc=1+10+321561276+0+321392110+321414712+321428316+321449549+321466733+321485767+321509060+321524365+321540252

      Ohje! Da ist wohl etwas schief gegangen.

      Fehler:

      Caught exception in MusicBrainz::Server::Controller::WS::2::DiscID->discid "DBD::Pg::st execute failed: ERROR: value "4285228133" is out of range for type integer
      ZEILE 2: ... cube_distance(toc, create_cube_from_durations('{42852281...
      ^ at lib/Sql.pm line 443.
      at lib/Sql.pm line 456.
      Sql::_ANON_("DBD::Pg::st execute failed: ERROR: value \"4285228133\" is out"...) called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 100
      Try::Tiny::try(CODE(0x14facdb0), Try::Tiny::Catch=REF(0x7f4deaf66510), Try::Tiny::Finally=REF(0x7f4deaf7ac88)) called at lib/Sql.pm line 460
      Sql::_select_list(Sql=HASH(0x14fa5670), "SELECT medium_index.medium AS medium,\x

      Unknown macro: {a}

      cub"..., ARRAY(0x7f4deaf80088), "hashref") called at lib/Sql.pm line 488
      Sql::select_list_of_hashes(Sql=HASH(0x14fa5670), "SELECT medium_index.medium AS medium,\x

      cub"..., 10, 10000) called at lib/MusicBrainz/Server/Data/DurationLookup.pm line 66
      MusicBrainz::Server::Data::DurationLookup::lookup(MusicBrainz::Server::Data::DurationLookup=HASH(0xd90a690), "1 10 321561276 0 321392110 321414712 321428316 321449549 3214"..., 10000) called at lib/MusicBrainz/Server/Controller/WS/2/DiscID.pm line 86
      MusicBrainz::Server::Controller::WS::2::DiscID::discid(MusicBrainz::Server::Controller::WS::2::DiscID=HASH(0xed08f08), MusicBrainz::Server=HASH(0x14bef7e8), "SFqeTSCDwsqEAiS8N9qtY.E_pig-") called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(Catalyst::Action=HASH(0xf179b90), MusicBrainz::Server::Controller::WS::2::DiscID=HASH(0xed08f08), MusicBrainz::Server=HASH(0x14bef7e8), "SFqeTSCDwsqEAiS8N9qtY.E_pig-") called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      eval

      Unknown macro: {...}

      called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      Catalyst::execute(MusicBrainz::Server=HASH(0x14bef7e8), "MusicBrainz::Server::Controller::WS::2::DiscID", Catalyst::Action=HASH(0xf179b90)) called at /home/beta/perl5/lib/perl5/Catalyst/Plugin/StackTrace.pm line 93
      Catalyst::Plugin::StackTrace::execute(MusicBrainz::Server=HASH(0x14bef7e8), "MusicBrainz::Server::Controller::WS::2::DiscID", Catalyst::Action=HASH(0xf179b90)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(Catalyst::Action=HASH(0xf179b90), MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/Catalyst/ActionChain.pm line 41
      Catalyst::ActionChain::dispatch(Catalyst::ActionChain=HASH(0x1509f940), MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/Catalyst/Controller.pm line 158
      Catalyst::Controller::_ACTION(MusicBrainz::Server::Controller::WS::2::DiscID=HASH(0xed08f08), MusicBrainz::Server=HASH(0x14bef7e8), "SFqeTSCDwsqEAiS8N9qtY.E_pig-") called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(Catalyst::Action=HASH(0xf179998), MusicBrainz::Server::Controller::WS::2::DiscID=HASH(0xed08f08), MusicBrainz::Server=HASH(0x14bef7e8), "SFqeTSCDwsqEAiS8N9qtY.E_pig-") called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      eval

      called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      Catalyst::execute(MusicBrainz::Server=HASH(0x14bef7e8), "MusicBrainz::Server::Controller::WS::2::DiscID", Catalyst::Action=HASH(0xf179998)) called at /home/beta/perl5/lib/perl5/Catalyst/Plugin/StackTrace.pm line 93
      Catalyst::Plugin::StackTrace::execute(MusicBrainz::Server=HASH(0x14bef7e8), "MusicBrainz::Server::Controller::WS::2::DiscID", Catalyst::Action=HASH(0xf179998)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(Catalyst::Action=HASH(0xf179998), MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward(Catalyst::Dispatcher=HASH(0x53dc9b0), "forward", MusicBrainz::Server=HASH(0x14bef7e8), "_ACTION") called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward(Catalyst::Dispatcher=HASH(0x53dc9b0), MusicBrainz::Server=HASH(0x14bef7e8), "_ACTION") called at /home/beta/perl5/lib/perl5/Catalyst.pm line 373
      Catalyst::forward(MusicBrainz::Server=HASH(0x14bef7e8), "_ACTION") called at /home/beta/perl5/lib/perl5/Catalyst/Controller.pm line 132
      Catalyst::Controller::_DISPATCH(MusicBrainz::Server::Controller::WS::2::DiscID=HASH(0xed08f08), MusicBrainz::Server=HASH(0x14bef7e8), "SFqeTSCDwsqEAiS8N9qtY.E_pig-") called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(Catalyst::Action=HASH(0xf176708), MusicBrainz::Server::Controller::WS::2::DiscID=HASH(0xed08f08), MusicBrainz::Server=HASH(0x14bef7e8), "SFqeTSCDwsqEAiS8N9qtY.E_pig-") called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      eval

      Unknown macro: {...}

      called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      Catalyst::execute(MusicBrainz::Server=HASH(0x14bef7e8), "MusicBrainz::Server::Controller::WS::2::DiscID", Catalyst::Action=HASH(0xf176708)) called at /home/beta/perl5/lib/perl5/Catalyst/Plugin/StackTrace.pm line 93
      Catalyst::Plugin::StackTrace::execute(MusicBrainz::Server=HASH(0x14bef7e8), "MusicBrainz::Server::Controller::WS::2::DiscID", Catalyst::Action=HASH(0xf176708)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(Catalyst::Action=HASH(0xf176708), MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward(Catalyst::Dispatcher=HASH(0x53dc9b0), "forward", MusicBrainz::Server=HASH(0x14bef7e8), "/ws/2/discid/_DISPATCH") called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward(Catalyst::Dispatcher=HASH(0x53dc9b0), MusicBrainz::Server=HASH(0x14bef7e8), "/ws/2/discid/_DISPATCH") called at /home/beta/perl5/lib/perl5/Catalyst.pm line 373
      Catalyst::forward(MusicBrainz::Server=HASH(0x14bef7e8), "/ws/2/discid/_DISPATCH") called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 105
      Catalyst::Dispatcher::dispatch(Catalyst::Dispatcher=HASH(0x53dc9b0), MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1633
      Catalyst::dispatch(MusicBrainz::Server=HASH(0x14bef7e8)) called at lib/MusicBrainz/Server.pm line 335
      MusicBrainz::Server::_ANON_() called at lib/MusicBrainz/Server.pm line 309
      MusicBrainz::Server::with_translations(MusicBrainz::Server=HASH(0x14bef7e8), CODE(0x101bd4a8)) called at lib/MusicBrainz/Server.pm line 336
      Class::MOP::Class:::around(CODE(0x4875530), MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server=HASH(0x14bef7e8)) called at lib/MusicBrainz/Server.pm line 350
      Class::MOP::Class:::around(CODE(0xf23b990), MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server=HASH(0x14bef7e8)) called at lib/MusicBrainz/Server.pm line 395
      Class::MOP::Class:::around(CODE(0xf23bff0), MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 35
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
      MusicBrainz::Server::dispatch(MusicBrainz::Server=HASH(0x14bef7e8)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1992
      Catalyst::_ANON_() called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 76
      eval

      called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 67
      Try::Tiny::try(CODE(0x7f4deaf7b060), Try::Tiny::Catch=REF(0x14c24770)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1998
      Catalyst::handle_request("MusicBrainz::Server", "env", HASH(0x14febbe0), "response_cb", CODE(0x14be3e78)) called at /home/beta/perl5/lib/perl5/Catalyst/Plugin/AutoRestart.pm line 117
      Catalyst::Plugin::AutoRestart::handle_request("MusicBrainz::Server", "env", HASH(0x14febbe0), "response_cb", CODE(0x14be3e78)) called at /home/beta/perl5/lib/perl5/Catalyst/Engine.pm line 697
      Catalyst::Engine::_ANON_(CODE(0x14be3e78)) called at /home/beta/perl5/lib/perl5/Plack/Handler/FCGI.pm line 136
      Plack::Handler::FCGI::run(Plack::Handler::FCGI=HASH(0x276cab8), CODE(0xf25c1b8)) called at /home/beta/perl5/lib/perl5/Plack/Loader.pm line 84
      Plack::Loader::run(Plack::Loader=HASH(0x2743eb0), Plack::Handler::FCGI=HASH(0x276cab8)) called at /home/beta/perl5/lib/perl5/Plack/Runner.pm line 277
      Plack::Runner::run(Plack::Runner=HASH(0x24e1600)) called at /home/beta/perl5/bin/plackup line 10"

      Stack-Trace:
      line 66 MusicBrainz::Server::Data::DurationLookup
      line 86 MusicBrainz::Server::Controller::WS::2::DiscID
      line 335 MusicBrainz::Server
      line 309 MusicBrainz::Server
      line 336 MusicBrainz::Server
      line 350 MusicBrainz::Server
      line 395 MusicBrainz::Server

      Anfragedaten:
      $VAR1 = {
      'query_parameters' =>

      Unknown macro: { 'cdstubs' => 'no', 'inc' => 'recordings artist-credits', 'toc' => '1 10 321561276 0 321392110 321414712 321428316 321449549 321466733 321485767 321509060 321524365 321540252' }

      ,
      'body_parameters' => {}
      };

      Zeit: 2014-05-22 10:35:17 UTC

      Host: pino

      Oberflächensprache: de

      URL: https://beta.musicbrainz.org/ws/2/discid/SFqeTSCDwsqEAiS8N9qtY.E_pig-?inc=recordings+artist-credits&cdstubs=no&toc=1+10+321561276+0+321392110+321414712+321428316+321449549+321466733+321485767+321509060+321524365+321540252

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ianmcorvidae Ian McEwen
                Reporter:
                nikki nikki
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved:

                  Packages

                  Version Package
                  2014-06-09