Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-7702

Reduce the duplication in link_* macros

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2014-07-07
    • Component/s: Refactoring, Templates
    • Labels:
      None

      Description

      The various link_artist, link_area, link_editor etc. macros mostly do the same thing, but each has its own code. The common parts should be factored out.

      In addition, duplicate conditions such as

      '<span class="name-variation">' IF text != '' AND text != artist.name AND action == 'show';
      ...
      '</span>' IF text != '' AND text != artist.name AND action == 'show';
      

      are prone to errors (MBS-7684) and should be combined, too.

        Attachments

          Activity

            People

            • Assignee:
              chirlu Ulrich Klauer
              Reporter:
              chirlu Ulrich Klauer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved: