Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-7963

Release editor doesn't prevent too long disambiguation comments

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2016-06-20
    • Component/s: Release editor
    • Labels:
      None

      Description

      The maximum length of a disambiguation comment in the database is 255 characters. The release editor does not prevent people from entering strings longer than that. If it's an auto-edit, the release editor fails to submit the edit at all, causing an internal server error, if the edit is votable, it's entered into the queue but then ModBot fails to apply it and it causes an internal server error if someone tries to approve it.

      The formhandler fields don't seem to have the same problem, they instead display an error like "Field should not exceed 255 characters. You entered 650".

      The ISE from approving:

      Fehler:

      Caught exception in MusicBrainz::Server::Controller::Edit->approve "Failed query:
      'UPDATE release SET packaging = ?, comment = ?, artist_credit = ?, barcode = ? WHERE id = ?'
      (1 Text on Back beneath Tracklist: The success of Bob Marley is due to the true feeling of his lyrics which he sings from the heart and while international success came from big multi-track studios in Europe, his heart, soul and music came from the small backroom studios in Jamaica. This compact-disc is taken from those original recordings, bringing you the real Bob Marley. 248826 837741)
      DBD::Pg::st execute failed: ERROR: value too long for type character varying(255) at lib/Sql.pm line 107, line 3.

      at lib/Sql.pm line 113, line 3.
      Sql::_ANON_("DBD::Pg::st execute failed: ERROR: value too long for type c"...) called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 100
      Try::Tiny::try(CODE(0x1731a3b8), Try::Tiny::Catch=REF(0x17a95988)) called at lib/Sql.pm line 114
      Sql::do(Sql=HASH(0x171c0bd0), "UPDATE release SET packaging = ?, comment = ?, artist_credit "..., 1, "Text on Back beneath Tracklist: The success of Bob Marley is "..., 248826, "", 837741) called at lib/Sql.pm line 200
      Sql::update_row(Sql=HASH(0x171c0bd0), "release", HASH(0x6005208), HASH(0x17a95868)) called at lib/MusicBrainz/Server/Data/Release.pm line 767
      MusicBrainz::Server::Data::Release::update(MusicBrainz::Server::Data::Release=HASH(0xe4fcfe0), 837741, HASH(0x173f33a0)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 56
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server::Data::Release=HASH(0xe4fcfe0), 837741, HASH(0x173f33a0)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
      MusicBrainz::Server::Data::Release::update(MusicBrainz::Server::Data::Release=HASH(0xe4fcfe0), 837741, HASH(0x173f33a0)) called at lib/MusicBrainz/Server/Edit/Generic/Edit.pm line 73
      MusicBrainz::Server::Edit::Generic::Edit::_ANON_() called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 76
      eval

      Unknown macro: {...}

      called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 67
      Try::Tiny::try(CODE(0x16e03fb8), Try::Tiny::Catch=REF(0x178b4d80)) called at lib/MusicBrainz/Server/Edit/Generic/Edit.pm line 91
      MusicBrainz::Server::Edit::Generic::Edit::_ANON_(MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Moose/Meta/Method/Overridden.pm line 38
      MusicBrainz::Server::Edit::Generic::Edit::accept(MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 50
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
      MusicBrainz::Server::Edit::Release::Edit::accept(MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8)) called at lib/MusicBrainz/Server/Data/Edit.pm line 652
      MusicBrainz::Server::Data::Edit::_ANON_() called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 71
      eval

      called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 67
      Try::Tiny::try(CODE(0x16fc4200), Try::Tiny::Catch=REF(0x17ac4830)) called at lib/MusicBrainz/Server/Data/Edit.pm line 687
      MusicBrainz::Server::Data::Edit::_do_accept(MusicBrainz::Server::Data::Edit=HASH(0xdaafee8), MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8)) called at lib/MusicBrainz/Server/Data/Edit.pm line 726
      MusicBrainz::Server::Data::Edit::_ANON_(MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8)) called at lib/MusicBrainz/Server/Data/Edit.pm line 749
      MusicBrainz::Server::Data::Edit::_close(MusicBrainz::Server::Data::Edit=HASH(0xdaafee8), MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8), CODE(0x16be1ac8)) called at lib/MusicBrainz/Server/Data/Edit.pm line 726
      MusicBrainz::Server::Data::Edit::accept(MusicBrainz::Server::Data::Edit=HASH(0xdaafee8), MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8)) called at lib/MusicBrainz/Server/Data/Edit.pm line 644
      MusicBrainz::Server::Data::Edit::approve(MusicBrainz::Server::Data::Edit=HASH(0xdaafee8), MusicBrainz::Server::Edit::Release::Edit=HASH(0x17a944b8), 53705) called at lib/MusicBrainz/Server/Controller/Edit.pm line 129
      MusicBrainz::Server::Controller::Edit::_ANON_() called at lib/Sql.pm line 316
      Sql::_ANON_() called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 71
      eval

      Unknown macro: {...}

      called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 67
      Try::Tiny::try(CODE(0x10e58758), Try::Tiny::Catch=REF(0x173166c8)) called at lib/Sql.pm line 330
      Sql::_auto_transaction(CODE(0x16deb920), Sql=HASH(0x171c0bd0)) called at lib/Sql.pm line 335
      Sql::_run_in_transaction_one(CODE(0x16deb920), Sql=HASH(0x171c0bd0)) called at lib/Sql.pm line 349
      Sql::run_in_transaction(CODE(0x16deb920), Sql=HASH(0x171c0bd0)) called at lib/MusicBrainz/Server/Model/MB.pm line 19
      MusicBrainz::Server::Model::MB::with_transaction(MusicBrainz::Server::Model::MB=HASH(0xd38b070), CODE(0x16deb920)) called at lib/MusicBrainz/Server/Controller/Edit.pm line 133
      MusicBrainz::Server::Controller::Edit::approve(MusicBrainz::Server::Controller::Edit=HASH(0xee67ca8), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(Catalyst::Action=HASH(0xf16af68), MusicBrainz::Server::Controller::Edit=HASH(0xee67ca8), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      eval

      called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      Catalyst::execute(MusicBrainz::Server=HASH(0x16d18200), "MusicBrainz::Server::Controller::Edit", Catalyst::Action=HASH(0xf16af68)) called at /home/beta/perl5/lib/perl5/Catalyst/Plugin/StackTrace.pm line 93
      Catalyst::Plugin::StackTrace::execute(MusicBrainz::Server=HASH(0x16d18200), "MusicBrainz::Server::Controller::Edit", Catalyst::Action=HASH(0xf16af68)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(Catalyst::Action=HASH(0xf16af68), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst/ActionChain.pm line 41
      Catalyst::ActionChain::dispatch(Catalyst::ActionChain=HASH(0x17aa2f30), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst/Controller.pm line 158
      Catalyst::Controller::_ACTION(MusicBrainz::Server::Controller::Edit=HASH(0xee67ca8), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(Catalyst::Action=HASH(0xf16ad28), MusicBrainz::Server::Controller::Edit=HASH(0xee67ca8), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      eval

      Unknown macro: {...}

      called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      Catalyst::execute(MusicBrainz::Server=HASH(0x16d18200), "MusicBrainz::Server::Controller::Edit", Catalyst::Action=HASH(0xf16ad28)) called at /home/beta/perl5/lib/perl5/Catalyst/Plugin/StackTrace.pm line 93
      Catalyst::Plugin::StackTrace::execute(MusicBrainz::Server=HASH(0x16d18200), "MusicBrainz::Server::Controller::Edit", Catalyst::Action=HASH(0xf16ad28)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(Catalyst::Action=HASH(0xf16ad28), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward(Catalyst::Dispatcher=HASH(0x4efcd78), "forward", MusicBrainz::Server=HASH(0x16d18200), "_ACTION") called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward(Catalyst::Dispatcher=HASH(0x4efcd78), MusicBrainz::Server=HASH(0x16d18200), "_ACTION") called at /home/beta/perl5/lib/perl5/Catalyst.pm line 373
      Catalyst::forward(MusicBrainz::Server=HASH(0x16d18200), "_ACTION") called at /home/beta/perl5/lib/perl5/Catalyst/Controller.pm line 132
      Catalyst::Controller::_DISPATCH(MusicBrainz::Server::Controller::Edit=HASH(0xee67ca8), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(Catalyst::Action=HASH(0xf163778), MusicBrainz::Server::Controller::Edit=HASH(0xee67ca8), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      eval

      called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1687
      Catalyst::execute(MusicBrainz::Server=HASH(0x16d18200), "MusicBrainz::Server::Controller::Edit", Catalyst::Action=HASH(0xf163778)) called at /home/beta/perl5/lib/perl5/Catalyst/Plugin/StackTrace.pm line 93
      Catalyst::Plugin::StackTrace::execute(MusicBrainz::Server=HASH(0x16d18200), "MusicBrainz::Server::Controller::Edit", Catalyst::Action=HASH(0xf163778)) called at /home/beta/perl5/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(Catalyst::Action=HASH(0xf163778), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward(Catalyst::Dispatcher=HASH(0x4efcd78), "forward", MusicBrainz::Server=HASH(0x16d18200), "/edit/_DISPATCH") called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward(Catalyst::Dispatcher=HASH(0x4efcd78), MusicBrainz::Server=HASH(0x16d18200), "/edit/_DISPATCH") called at /home/beta/perl5/lib/perl5/Catalyst.pm line 373
      Catalyst::forward(MusicBrainz::Server=HASH(0x16d18200), "/edit/_DISPATCH") called at /home/beta/perl5/lib/perl5/Catalyst/Dispatcher.pm line 105
      Catalyst::Dispatcher::dispatch(Catalyst::Dispatcher=HASH(0x4efcd78), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1633
      Catalyst::dispatch(MusicBrainz::Server=HASH(0x16d18200)) called at lib/MusicBrainz/Server.pm line 328
      MusicBrainz::Server::_ANON_() called at lib/MusicBrainz/Server.pm line 302
      MusicBrainz::Server::with_translations(MusicBrainz::Server=HASH(0x16d18200), CODE(0x17dc4818)) called at lib/MusicBrainz/Server.pm line 329
      Class::MOP::Class:::around(CODE(0x43619e0), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server=HASH(0x16d18200)) called at lib/MusicBrainz/Server.pm line 343
      Class::MOP::Class:::around(CODE(0xf434c38), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server=HASH(0x16d18200)) called at lib/MusicBrainz/Server.pm line 388
      Class::MOP::Class:::around(CODE(0xd2577b0), MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 35
      Class::MOP::Method::Wrapped::_ANON_(MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
      MusicBrainz::Server::dispatch(MusicBrainz::Server=HASH(0x16d18200)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1992
      Catalyst::_ANON_() called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 76
      eval

      Unknown macro: {...}

      called at /usr/local/share/perl/5.10.1/Try/Tiny.pm line 67
      Try::Tiny::try(CODE(0x17324238), Try::Tiny::Catch=REF(0x17ddfe60)) called at /home/beta/perl5/lib/perl5/Catalyst.pm line 1998
      Catalyst::handle_request("MusicBrainz::Server", "env", HASH(0xf8708f0), "response_cb", CODE(0x17799530)) called at /home/beta/perl5/lib/perl5/Catalyst/Plugin/AutoRestart.pm line 117
      Catalyst::Plugin::AutoRestart::handle_request("MusicBrainz::Server", "env", HASH(0xf8708f0), "response_cb", CODE(0x17799530)) called at /home/beta/perl5/lib/perl5/Catalyst/Engine.pm line 697
      Catalyst::Engine::_ANON_(CODE(0x17799530)) called at /home/beta/perl5/lib/perl5/Plack/Handler/FCGI.pm line 136
      Plack::Handler::FCGI::run(Plack::Handler::FCGI=HASH(0x23b6ab8), CODE(0xf45c490)) called at /home/beta/perl5/lib/perl5/Plack/Loader.pm line 84
      Plack::Loader::run(Plack::Loader=HASH(0x238deb0), Plack::Handler::FCGI=HASH(0x23b6ab8)) called at /home/beta/perl5/lib/perl5/Plack/Runner.pm line 277
      Plack::Runner::run(Plack::Runner=HASH(0x212b600)) called at /home/beta/perl5/bin/plackup line 10
      at lib/Sql.pm line 330."

      Stack-Trace:
      line 19 MusicBrainz::Server::Model::MB
      line 133 MusicBrainz::Server::Controller::Edit
      line 328 MusicBrainz::Server
      line 302 MusicBrainz::Server
      line 329 MusicBrainz::Server
      line 343 MusicBrainz::Server
      line 388 MusicBrainz::Server

      Anfragedaten:
      $VAR1 = {
      'query_parameters' => {},
      'body_parameters' => {}
      };

        Attachments

          Activity

            People

            • Assignee:
              bitmap Michael Wiencek
              Reporter:
              nikki nikki
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Packages

                Version Package
                2016-06-20