Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-8725

Allow mediums to have an unknown tracklist

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2020-10-19
    • None
    • Release editor
    • None

      Currently you can add a release with no tracklist. However, this is done by removing all the mediums from the release.

      This means you can't specify if you know that it's a cassette/CD/etc. but don't know the tracklist on each medium.

      So it would be better if "unknown tracklist" were an attribute of the medium rather than the release.

          [MBS-8725] Allow mediums to have an unknown tracklist

          eloise_freya: could you add a new ticket for that? It sounds possibly reasonable to me, as long as the medium isn't otherwise changed (name, format).

          Nicolás Tamargo added a comment - eloise_freya : could you add a new ticket for that? It sounds possibly reasonable to me, as long as the medium isn't otherwise changed (name, format).

          Eloise Freya added a comment -

          If someone adds a track listing so a medium which previously was marked "unknown" can it go through automatically?

          Currently it's put through 7 day voting process.

           

          Eloise Freya added a comment - If someone adds a track listing so a medium which previously was marked "unknown" can it go through automatically? Currently it's put through 7 day voting process.  

          chaban added a comment -

          Unfortunately I wasn't able to reproduce this: https://musicbrainz.org/edit/74709728 but it's possible other users were plagued by it too as I've seen some editors adding new mediums instead of editing the existing unknown one.

          Another user reports that a new medium was added instead: https://musicbrainz.org/edit/74807840

          chaban added a comment - Unfortunately I wasn't able to reproduce this: https://musicbrainz.org/edit/74709728 but it's possible other users were plagued by it too as I've seen some editors adding new mediums instead of editing the existing unknown one. Another user reports that a new medium was added instead: https://musicbrainz.org/edit/74807840

          Nicolás Tamargo added a comment - - edited

          Hmm! I wasn't expecting that to be honest, but actually I'd consider it an improvement over them just giving up and not adding the release at all   I guess I should write (and start following) a report about empty mediums.

          Nicolás Tamargo added a comment - - edited Hmm! I wasn't expecting that to be honest, but actually I'd consider it an improvement over them just giving up and not adding the release at all   I guess I should write (and start following) a report about empty mediums.

          chaban added a comment - It looks like beginners resort to this feature if they can't figure out how to use the tracklist editor. An example: https://musicbrainz.org/edit/74709728 More cases where the tracklist was omitted: https://musicbrainz.org/edit/74583209 https://musicbrainz.org/edit/74582657 https://musicbrainz.org/edit/74582394 https://musicbrainz.org/edit/74562582 https://musicbrainz.org/edit/74561337 https://musicbrainz.org/edit/74558009 https://musicbrainz.org/edit/74552723 https://musicbrainz.org/edit/74545765 https://musicbrainz.org/edit/74539666 https://musicbrainz.org/edit/74514433 https://musicbrainz.org/edit/74510741 https://musicbrainz.org/edit/74508951 https://musicbrainz.org/edit/74519111 https://musicbrainz.org/edit/74501213 https://musicbrainz.org/edit/74504980 https://musicbrainz.org/edit/74599488 https://musicbrainz.org/edit/74603626

          David Kellner added a comment -

          draconx: This is MBS-11066 which also occurred on beta before the last PR but was now fixed there, so this problem should go away on the production server as well after the next release.

          David Kellner added a comment - draconx : This is MBS-11066 which also occurred on beta before the last PR but was now fixed there, so this problem should go away on the production server as well after the next release.

          draconx added a comment -

          These edits created on the beta site appear to be breaking the main site. Seems to give an internal server error if an edit search happens to pulls up such an edit.

          For example: https://musicbrainz.org/release/369a717a-38f7-406f-b830-57929e168792/edits

          Internal Server Error
          
          Oops, something went wrong!
          
          Error:
          
          Couldn't render template "undef error - TypeError: Cannot read property 'position' of undefined
              at E (/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js:1:725983)
              at d (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:36:498)
              at $a (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:39:16)
              at a.b.render (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:44:476)
              at a.b.read (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:44:18)
              at Object.renderToString (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:54:364)
              at getResponse (/home/musicbrainz/musicbrainz-server/root/server/response.js:102:31)
              at Socket.receiveData (/home/musicbrainz/musicbrainz-server/root/server/createServer.js:83:31)
              at Socket.emit (events.js:198:13)
              at Socket.EventEmitter.emit (domain.js:448:20) at lib/MusicBrainz/Server/Plugin/React.pm line 18.
          "
          
          Stack trace:
          
              line
              line
          
          Edits loaded for the page:
          
              73843637 (raw edit data); fully loaded
              73167965 (raw edit data); fully loaded
              73167963 (raw edit data); fully loaded
          
          Time: 2020-10-13 15:48:34 UTC
          
          Host: 833d61e372ec
          
          Interface language: en
          
          URL: https://musicbrainz.org/release/369a717a-38f7-406f-b830-57929e168792/edits
          
          Request data:
          
          $VAR1 = {
                    'query_parameters' => {},
                    'body_parameters' => {}
                  };
              
          
          We're terribly sorry for this problem. Please wait a few minutes and repeat your request — the problem may go away.
          
          If the problem persists, please report a bug and include any error message that is shown above.
          
          Please be sure to include the stack trace and request data shown above!
          

          draconx added a comment - These edits created on the beta site appear to be breaking the main site. Seems to give an internal server error if an edit search happens to pulls up such an edit. For example: https://musicbrainz.org/release/369a717a-38f7-406f-b830-57929e168792/edits Internal Server Error Oops, something went wrong! Error: Couldn't render template "undef error - TypeError: Cannot read property 'position' of undefined at E (/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js:1:725983) at d (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:36:498) at $a (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:39:16) at a.b.render (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:44:476) at a.b.read (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:44:18) at Object.renderToString (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:54:364) at getResponse (/home/musicbrainz/musicbrainz-server/root/server/response.js:102:31) at Socket.receiveData (/home/musicbrainz/musicbrainz-server/root/server/createServer.js:83:31) at Socket.emit (events.js:198:13) at Socket.EventEmitter.emit (domain.js:448:20) at lib/MusicBrainz/Server/Plugin/React.pm line 18. " Stack trace: line line Edits loaded for the page: 73843637 (raw edit data); fully loaded 73167965 (raw edit data); fully loaded 73167963 (raw edit data); fully loaded Time: 2020-10-13 15:48:34 UTC Host: 833d61e372ec Interface language: en URL: https://musicbrainz.org/release/369a717a-38f7-406f-b830-57929e168792/edits Request data: $VAR1 = { 'query_parameters' => {}, 'body_parameters' => {} }; We're terribly sorry for this problem. Please wait a few minutes and repeat your request — the problem may go away. If the problem persists, please report a bug and include any error message that is shown above. Please be sure to include the stack trace and request data shown above!

          Psychoadept added a comment - - edited

          Of course, I've found that track list since then. But here's another: https://beta.musicbrainz.org/release/369a717a-38f7-406f-b830-57929e168792

          Psychoadept added a comment - - edited Of course, I've found that track list since then. But here's another: https://beta.musicbrainz.org/release/369a717a-38f7-406f-b830-57929e168792

          Psychoadept added a comment -

          Psychoadept added a comment - So far so good: https://beta.musicbrainz.org/release/62ad0f78-da86-4fae-abfe-e5918b119fee

          GitHub Bot added a comment -

          See code changes in pull request #1633 submitted by reosarevok.

          GitHub Bot added a comment - See code changes in pull request #1633 submitted by reosarevok .

            reosarevok Nicolás Tamargo
            hawke Alex Mauer
            Votes:
            13 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2020-10-19