Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-8874

Editing an entity sometimes shows it as a possible duplicate of itself

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2016-04-04
    • Component/s: Editing interface
    • Labels:
      None

      Description

      http://chatlogs.metabrainz.org/brainzbot/metabrainz/2016-03-26/?msg=3550090&page=4

      After some investigation, we found that it's sending an empty mbid parameter to /ws/js/check_duplicates, so https://github.com/metabrainz/musicbrainz-server/blob/f630a14/lib/MusicBrainz/Server/Controller/WS/js/CheckDuplicates.pm#L43-L43 isn't working.

      Not sure why it's doing that. It should take the mbid from "MB.sourceEntityGID" on the page, which is set by the relationship editor code, and that code should always run before the duplicate-checking code. We can try to have it get the mbid from the window.location href instead.

        Attachments

          Activity

            People

            Assignee:
            bitmap Michael Wiencek
            Reporter:
            bitmap Michael Wiencek
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Due:
              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                2016-04-04