Uploaded image for project: 'Other'
  1. Other
  2. OTHER-392

MetaBrainz wide Pull request review policy

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None

      Our different projects have different pull request review policies, some might be a bit too loose and some a bit too strict (this is not great for productivity).
      MB have a team meeting every two weeks or so, choose 20 PRs to review and do two reviewers for each. Sometimes short fixes for regressions / when someone is on vacation PRs can get merged with one reviewer.

      However: some projects have different processes and a general policy might not apply to all projects' pull requests.

      Proposed policy:

      • Every PR needs at least one review
        • That should be good enough for trivial patches
      • PR authors should request more reviewers depending on the potential danger of uncaught issues in the code being modified
      • Other team members can also assign themselves to review or ask for another reviewer if they disagree with the number required by the PR author
      • If docs are in the same repo, we should request they be amended along with any PR that changes the code. If docs are separate, we should request those changes in the PR template and ask contributors to write the docs

      @mr_monkey doesn't have anyone to review his PRs in BookBrainz `😢`. But will from here onwards ask other team members who do JS (@reosarevok?) to review PRs

            Unassigned Unassigned
            ApekattQuest, MonkeyPython MonkeyPython
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package