Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1013

False file save error in specific circumstances

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.1
    • 1.4, 2.0.4
    • File Move & Rename
    • None
    • Windows 10

      If you rip a multi-CD album using Windows Media Player you get files like this:

      Album CD1\01 Track 01
      Album CD1\02 Track 02
      Album CD1\03 Track 03
      Album CD1\AlbumArt_small.jpg
      Album CD1\Folder.jpg
      Album CD2\01 Track 01
      Album CD2\02 Track 02
      Album CD2\03 Track 03
      Album CD2\AlbumArt_small.jpg
      Album CD2\Folder.jpg

      The jpg files in the two directories might be the same or might be different.

      When you put all these into one Album in Picard and save it then it deals with the CD1 files fine, moving the jpg files over, but whilst it moves the music files for CD2 ok, it shows them with a file save error (Invalid Permissions) because the jpg files already exist and it can't move them.

      Picard needs to distinguish between errors moving music tracks and errors move additional files.

          [PICARD-1013] False file save error in specific circumstances

          As expected this was fixed by the fix of PICARD-1346. It is not strictly speaking a duplicate, but a variation of PICARD-1346.

          Philipp Wolfer added a comment - As expected this was fixed by the fix of PICARD-1346 . It is not strictly speaking a duplicate, but a variation of PICARD-1346 .

          Also on Picard 2.0.4:

          {{E: 14:50:04,355 /home/phw/devel/musicbrainz/picard/picard/util/thread.run:51: Traceback (most recent call last):
          File "/usr/lib/python3.7/shutil.py", line 557, in move
          os.rename(src, real_dst)
          FileNotFoundError: [Errno 2] No such file or directory: '/home/phw/Musik/Paradise Lost/Disc 1 (Kopie)/AlbumArt.jpg' -> '/home/phw/Musik/Tagged/lossy/P/Paradise Lost/Shades of God/AlbumArt.jpg'

          During handling of the above exception, another exception occurred:

          Traceback (most recent call last):
          File "/home/phw/devel/musicbrainz/picard/picard/util/thread.py", line 47, in run
          result = self.func()
          File "/home/phw/devel/musicbrainz/picard/picard/file.py", line 221, in _save_and_rename
          self._move_additional_files(old_filename, new_filename)
          File "/home/phw/devel/musicbrainz/picard/picard/file.py", line 438, in _move_additional_files
          shutil.move(old_file, new_file)
          File "/usr/lib/python3.7/shutil.py", line 571, in move
          copy_function(src, real_dst)
          File "/usr/lib/python3.7/shutil.py", line 257, in copy2
          copyfile(src, dst, follow_symlinks=follow_symlinks)
          File "/usr/lib/python3.7/shutil.py", line 120, in copyfile
          with open(src, 'rb') as fsrc:
          FileNotFoundError: [Errno 2] No such file or directory: '/home/phw/Musik/Paradise Lost/Disc 1 (Kopie)/AlbumArt.jpg'

          E: 14:50:04,420 /home/phw/devel/musicbrainz/picard/picard/util/thread.run:51: Traceback (most recent call last):
          File "/usr/lib/python3.7/shutil.py", line 557, in move
          os.rename(src, real_dst)
          FileNotFoundError: [Errno 2] No such file or directory: '/home/phw/Musik/Paradise Lost/Disc 2 (Kopie)/AlbumArt.jpg' -> '/home/phw/Musik/Tagged/lossy/P/Paradise Lost/Shades of God/AlbumArt.jpg'

          During handling of the above exception, another exception occurred:

          Traceback (most recent call last):
          File "/home/phw/devel/musicbrainz/picard/picard/util/thread.py", line 47, in run
          result = self.func()
          File "/home/phw/devel/musicbrainz/picard/picard/file.py", line 221, in _save_and_rename
          self._move_additional_files(old_filename, new_filename)
          File "/home/phw/devel/musicbrainz/picard/picard/file.py", line 438, in _move_additional_files
          shutil.move(old_file, new_file)
          File "/usr/lib/python3.7/shutil.py", line 571, in move
          copy_function(src, real_dst)
          File "/usr/lib/python3.7/shutil.py", line 257, in copy2
          copyfile(src, dst, follow_symlinks=follow_symlinks)
          File "/usr/lib/python3.7/shutil.py", line 120, in copyfile
          with open(src, 'rb') as fsrc:
          FileNotFoundError: [Errno 2] No such file or directory: '/home/phw/Musik/Paradise Lost/Disc 2 (Kopie)/AlbumArt.jpg'}}

          Philipp Wolfer added a comment - Also on Picard 2.0.4: {{E: 14:50:04,355 /home/phw/devel/musicbrainz/picard/picard/util/thread.run:51: Traceback (most recent call last): File "/usr/lib/python3.7/shutil.py", line 557, in move os.rename(src, real_dst) FileNotFoundError: [Errno 2] No such file or directory: '/home/phw/Musik/Paradise Lost/Disc 1 (Kopie)/AlbumArt.jpg' -> '/home/phw/Musik/Tagged/lossy/P/Paradise Lost/Shades of God/AlbumArt.jpg' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/phw/devel/musicbrainz/picard/picard/util/thread.py", line 47, in run result = self.func() File "/home/phw/devel/musicbrainz/picard/picard/file.py", line 221, in _save_and_rename self._move_additional_files(old_filename, new_filename) File "/home/phw/devel/musicbrainz/picard/picard/file.py", line 438, in _move_additional_files shutil.move(old_file, new_file) File "/usr/lib/python3.7/shutil.py", line 571, in move copy_function(src, real_dst) File "/usr/lib/python3.7/shutil.py", line 257, in copy2 copyfile(src, dst, follow_symlinks=follow_symlinks) File "/usr/lib/python3.7/shutil.py", line 120, in copyfile with open(src, 'rb') as fsrc: FileNotFoundError: [Errno 2] No such file or directory: '/home/phw/Musik/Paradise Lost/Disc 1 (Kopie)/AlbumArt.jpg' E: 14:50:04,420 /home/phw/devel/musicbrainz/picard/picard/util/thread.run:51: Traceback (most recent call last): File "/usr/lib/python3.7/shutil.py", line 557, in move os.rename(src, real_dst) FileNotFoundError: [Errno 2] No such file or directory: '/home/phw/Musik/Paradise Lost/Disc 2 (Kopie)/AlbumArt.jpg' -> '/home/phw/Musik/Tagged/lossy/P/Paradise Lost/Shades of God/AlbumArt.jpg' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/phw/devel/musicbrainz/picard/picard/util/thread.py", line 47, in run result = self.func() File "/home/phw/devel/musicbrainz/picard/picard/file.py", line 221, in _save_and_rename self._move_additional_files(old_filename, new_filename) File "/home/phw/devel/musicbrainz/picard/picard/file.py", line 438, in _move_additional_files shutil.move(old_file, new_file) File "/usr/lib/python3.7/shutil.py", line 571, in move copy_function(src, real_dst) File "/usr/lib/python3.7/shutil.py", line 257, in copy2 copyfile(src, dst, follow_symlinks=follow_symlinks) File "/usr/lib/python3.7/shutil.py", line 120, in copyfile with open(src, 'rb') as fsrc: FileNotFoundError: [Errno 2] No such file or directory: '/home/phw/Musik/Paradise Lost/Disc 2 (Kopie)/AlbumArt.jpg'}}

          Philipp Wolfer added a comment - - edited

          This might be a duplicate of or related to PICARD-1346

          Philipp Wolfer added a comment - - edited This might be a duplicate of or related to PICARD-1346

            outsidecontext Philipp Wolfer
            sophist Sophist
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.1