Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-105

Picard won't load non-album tracks from fingerprints

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.1
    • 1.4.2, 2.0.4
    • None
    • Linux (Ubuntu 11.10)

      Picard won't load a track based on its fingerprint, if it does not appear on any release. It should.

      Example recordings:
      http://musicbrainz.org/recording/eeaaa7bc-0289-4f1c-ad15-fa0d1041c345
      http://musicbrainz.org/recording/8b3abab1-c4af-4f6f-84b2-1c716d5477fc

      Both are available from
      http://blog.wfmu.org/freeform/2006/05/stairways_to_he.html

      Both have acoustIDs associated with their fingerprints, but Picard will neither load the non-album tracks, nor move the files to the appropriate release if the non-album tracks have been loaded manually.

          [PICARD-105] Picard won't load non-album tracks from fingerprints

          Even if Picard only gets the recording ID it still is possible to load the track as NAT. The PR at https://github.com/metabrainz/picard/pull/961 enabled Picard to do this.

          Philipp Wolfer added a comment - Even if Picard only gets the recording ID it still is possible to load the track as NAT. The PR at https://github.com/metabrainz/picard/pull/961 enabled Picard to do this.

          Zas added a comment -

          Luks: is this fixed ?

          Zas added a comment - Luks: is this fixed ?

          Sorry, it's still not fixed. The straight-forward fix is too slow, so I'll have to do more changes in the AcoustID server than I expected.

          Lukáš Lalinský added a comment - Sorry, it's still not fixed. The straight-forward fix is too slow, so I'll have to do more changes in the AcoustID server than I expected.

          MLL added a comment -

          Hello there. Any update on this ? I can confirm this bug is still lingering.

          MLL added a comment - Hello there. Any update on this ? I can confirm this bug is still lingering.

          This looks like a bug in the Acoustid server. I'll try to fix it tomorrow.

          Lukáš Lalinský added a comment - This looks like a bug in the Acoustid server. I'll try to fix it tomorrow.

          voiceinsideyou added a comment - - edited

          Interestingly, I notice I get a more useful response if I remove "releases releasegroups tracks" from the "meta" parameter, which might be enough information to make Picard load these as NATs; although there is still some more work required.

          http://tinyurl.com/6msa7b2 (acoustid lookup link)

          <response>
          <status>ok</status>
          <results>
            <result>
              <recordings>
                <recording>
                  <duration>165</duration>
                  <title>Just Like Heaven (live) (The Cure)</title>
                  <id>729587b6-9e87-4e85-b621-6d755e92cb53</id>
                  <artists>
                    <artist>
                      <id>9bf79f68-c064-44a1-8c2c-5764f1d7c016</id>
                      <name>Richard Cheese</name>
                    </artist>
                  </artists>
                </recording>
                <recording>
                  <duration>213</duration>
                  <title>Stairway to Heaven</title>
                  <id>eeaaa7bc-0289-4f1c-ad15-fa0d1041c345</id>
                  <artists>
                    <artist>
                      <id>9bf79f68-c064-44a1-8c2c-5764f1d7c016</id>
                      <name>Richard Cheese</name>
                    </artist>
                  </artists>
                </recording>
              </recordings>
              <score>0.952663</score>
              <id>3a408ffc-a6e7-4c18-af71-d0cdffee85c2</id>
            </result>
          </results>
          </response>
          

          voiceinsideyou added a comment - - edited Interestingly, I notice I get a more useful response if I remove "releases releasegroups tracks" from the "meta" parameter, which might be enough information to make Picard load these as NATs; although there is still some more work required. http://tinyurl.com/6msa7b2 (acoustid lookup link) <response> <status> ok </status> <results> <result> <recordings> <recording> <duration> 165 </duration> <title> Just Like Heaven (live) (The Cure) </title> <id> 729587b6-9e87-4e85-b621-6d755e92cb53 </id> <artists> <artist> <id> 9bf79f68-c064-44a1-8c2c-5764f1d7c016 </id> <name> Richard Cheese </name> </artist> </artists> </recording> <recording> <duration> 213 </duration> <title> Stairway to Heaven </title> <id> eeaaa7bc-0289-4f1c-ad15-fa0d1041c345 </id> <artists> <artist> <id> 9bf79f68-c064-44a1-8c2c-5764f1d7c016 </id> <name> Richard Cheese </name> </artist> </artists> </recording> </recordings> <score> 0.952663 </score> <id> 3a408ffc-a6e7-4c18-af71-d0cdffee85c2 </id> </result> </results> </response>

          Hi luks - do you know what's going on with these? It looks to me that the recording coming back from the acoustid web service has no metadata so is being ignored by the check in acoustid.py:61.

          For the Richard Cheese track we get back

          <?xml version='1.0' encoding='UTF-8'?>
          <response>
          <status>ok</status>
          <results>
            <result>
              <recordings>
                <recording>
                  <id>729587b6-9e87-4e85-b621-6d755e92cb53</id>
                </recording>
                <recording>
                  <id>eeaaa7bc-0289-4f1c-ad15-fa0d1041c345</id>
                </recording>
              </recordings>
              <score>0.952663</score>
              <id>3a408ffc-a6e7-4c18-af71-d0cdffee85c2</id>
            </result>
          </results>
          </response>
          

          Should it at least be able to get some base metadata? Title and artist credit - to try and make a sensible match choice?

          voiceinsideyou added a comment - Hi luks - do you know what's going on with these? It looks to me that the recording coming back from the acoustid web service has no metadata so is being ignored by the check in acoustid.py:61. For the Richard Cheese track we get back <?xml version= '1.0' encoding= 'UTF-8' ?> <response> <status> ok </status> <results> <result> <recordings> <recording> <id> 729587b6-9e87-4e85-b621-6d755e92cb53 </id> </recording> <recording> <id> eeaaa7bc-0289-4f1c-ad15-fa0d1041c345 </id> </recording> </recordings> <score> 0.952663 </score> <id> 3a408ffc-a6e7-4c18-af71-d0cdffee85c2 </id> </result> </results> </response> Should it at least be able to get some base metadata? Title and artist credit - to try and make a sensible match choice?

          Johannes W added a comment -

          I can confirm this, I'm pretty sure it is a regression, as it worked not so long ago.

          Johannes W added a comment - I can confirm this, I'm pretty sure it is a regression, as it worked not so long ago.

            outsidecontext Philipp Wolfer
            hawke Alex Mauer
            Votes:
            8 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.1