Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1178

Images tagged with extra types that the user has chosen to ignore should not be shown as 'modified'

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 2.0.0dev2
    • Fix Version/s: 2.1.3
    • Component/s: Cover Art
    • Labels:

      Description

      If the user has configured Picard to download only images of type X (e.g. 'front'), and an image on CAA is tagged as both X and Y (e.g. 'front' and 'booklet'), then the album is shown as 'modified' after a look-up. If the 'new' data are then saved, the album will again show as 'modified' next time it is looked up.

      I think Picard should ignore image tags from CAA that correspond to types that the user has chosen not to download.

      Suggested fix: in CoverArtImage._init_ in image.py, change:

      else:
          self.types = types
      

      to:

      else:
          self.types = [t for t in types if t in config.setting["caa_image_types"]]
      

      Works for me.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                outsidecontext Philipp Wolfer
                Reporter:
                obtext Alec Edgington
              • Votes:
                3 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Packages

                  Version Package
                  2.1.3