Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1181

In-app search dialog excessive slow down

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Component/s: Other
    • Labels:
      None

      Description

      In-app search dialog may retrieve a lot of cover art images. Current code is slowing down requests in case of server errors, but it applies this slow down to every kind of error.

       

      E: 16:44:01 Network request error for https://coverartarchive.org:443/release/2aadf2c6-bce0-47e1-96ce-73fb42284475: Error transferring https://coverartarchive.org:443/release/2aadf2c6-bce0-47e1-96ce-73fb42284475 - server replied: NOT FOUND (QT code 203, HTTP code 404)
      D: 16:44:01 WebService: ('coverartarchive.org', 443): delay: 32000ms -> 32000ms.
      D: 16:44:01 WebService: ('coverartarchive.org', 443): ssthresh: 0.
      D: 16:44:01 WebService: ('coverartarchive.org', 443): cws: 1.000.
      D: 16:44:01 WSREQ: Last request to ('coverartarchive.org', 443) was 174 ms ago, waiting 31826 ms before starting another one
      D: 16:44:33 WSREQ: Last request to ('coverartarchive.org', 443) was 31994 ms ago, waiting 6 ms before starting another one
      D: 16:44:33 WSREQ: Last request to ('coverartarchive.org', 443) was 32000 ms ago, starting another one
      D: 16:44:33 WebService: ('coverartarchive.org', 443): outstanding reqs: 1
      D: 16:44:33 WebService: ('coverartarchive.org', 443): outstanding reqs: 0
      E: 16:44:33 Network request error for https://coverartarchive.org:443/release/a1c0f439-b675-4c3e-bcfe-533cb748ffb7: Error transferring https://coverartarchive.org:443/release/a1c0f439-b675-4c3e-bcfe-533cb748ffb7 - server replied: NOT FOUND (QT code 203, HTTP code 404)
      D: 16:44:33 WebService: ('coverartarchive.org', 443): delay: 32000ms -> 32000ms.
      D: 16:44:33 WebService: ('coverartarchive.org', 443): ssthresh: 0.
      D: 16:44:33 WebService: ('coverartarchive.org', 443): cws: 1.000.
      D: 16:44:33 WSREQ: Last request to ('coverartarchive.org', 443) was 128 ms ago, waiting 31872 ms before starting another one
      D: 16:45:05 WSREQ: Last request to ('coverartarchive.org', 443) was 31993 ms ago, waiting 7 ms before starting another one
      D: 16:45:05 WSREQ: Last request to ('coverartarchive.org', 443) was 32001 ms ago, starting another one

       

      Here last requests are delayed by 32s (which is the max delay).
      This behavior is incorrect, Picard shouldn't slow down because of those 404s (which are legit, cover art doesn't exist).

       

      Related code is at

      https://github.com/metabrainz/picard/blob/b0c690da2cb19bebb41770338a30be946757213b/picard/webservice/__init__.py#L489

        Attachments

          Activity

            People

            • Assignee:
              zas Zas
              Reporter:
              zas Zas
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: