Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1287

Picard crashes "Replace non-ASCII characters"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: File Move & Rename
    • Environment:
      Gentoo Linux, btrfs

      Description

      I'm getting an error whenever I check "rename files" option. I think it is related to the "É" in the example track name.

      Traceback (most recent call last):
        File "/usr/lib64/python3.5/site-packages/picard/ui/options/renaming.py", line 163, in update_examples
          example2 = self._example_to_filename(self.example_2())
        File "/usr/lib64/python3.5/site-packages/picard/ui/options/renaming.py", line 148, in _example_to_filename
          filename = file._make_filename(file.filename, file.metadata, settings)
        File "/usr/lib64/python3.5/site-packages/picard/file.py", line 373, in _make_filename
          return os.path.realpath(os.path.join(new_dirname, new_filename))
        File "/usr/lib64/python3.5/posixpath.py", line 373, in realpath
          path, ok = _joinrealpath(filename[:0], filename, {})
        File "/usr/lib64/python3.5/posixpath.py", line 407, in _joinrealpath
          if not islink(newpath):
        File "/usr/lib64/python3.5/posixpath.py", line 161, in islink
          st = os.lstat(path)
      UnicodeEncodeError: 'ascii' codec can't encode character '\xc9' in position 43: ordinal not in range(128)
      Aborted
      

      I first triggered this by checking "move files", then checking "rename files". This is I assume because "remove non-ASCII" is not checked by default.

      I worked around that by checking "rename files" first, then "replace non-ASCII", then "move files".

      Then, because my filesystem and all devices I'd be using the files aren't using silly filesystems, I tried to uncheck "replace non-ASCII". This causes a crash with the exact same message as above.

      I tried unchecking "move files", since at first when both "move" and "rename" were unchecked, and "replace" was in its default unchecked state, I was able to have "rename" without "replace". But now unchecking "replace" in any case crashes Picard.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                petteyg Gordon Pettey
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Packages

                  Version Package