Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1326

Picard Save Changes 5.1 Mix Type

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.0.4
    • 1.4.2, 2.0.3
    • Tags & Metadata
    • None
    • Linux

      Not entirely sure how this is possible as I wasn't aware it was saved as a tag, but I've now double checked this using two different audio files and it's definitely happening.

      When saving a 5.1 audio file in Picard (with Rename, Move, Save Tags enabled) it seems to change 5.1 audio files to 5.1(side) mapping instead.

      The target files in question are 6 channel FLAC files. Here's one of the files being played in MPV before being tagged with Picard:

      {{ Audio --aid=1 (flac 6ch 44100Hz)
      File tags:
      Artist: REM
      Album: Automatic For The People
      Title: Drive
      Track: 1
      AO: [pulse] 44100Hz 5.1 6ch s32
      A: 00:04:30 / 00:04:31 (99%) Cache: 0s}}

      Then, after tagging with Picard:

      {{ Audio --aid=1 (flac 6ch 44100Hz)
      File tags:
      Artist: R.E.M.
      Album: Automatic for the People
      Album_Artist: R.E.M.
      Comment: Chillout (Songs-DB_Occasion);Male Vocalist (Songs-DB_Custom2);Singer-Songwriter (Songs-DB_Custom2);American (Songs-DB_Custom4);Athens (Songs-DB_Custom3);80s (Songs-DB_Custom1)
      Date: 2002-12-03
      Genre: Alternative Rock;Alternative;Indie Rock;College Rock
      Title: Drive (5.1 mix)
      Track: 13
      AO: [pulse] 44100Hz 5.1(side) 6ch s32
      A: 00:00:10 / 00:04:31 (4%) Cache: 259s+118MB}}

      Notice how it's changed from 44100Hz 5.1 6ch s32 to 44100Hz 5.1(side) 6ch s32.

      Now idea how or why Picard is doing this, especially as to fix it requires reencoding it with FFMPEG to change the speaker mapping back.

      (Style >> Preformatted doesn't work by the way, the curly braces don't seem to do anything)

          [PICARD-1326] Picard Save Changes 5.1 Mix Type

          Benjamin Hodgetts added a comment -

          Thanks Philipp. Correct, I have clear existing tags on (to remove any old cruft) and disabling that option (or adding the exclusion as you mentioned) both negate the problem.

          Thanks for getting on this so quickly, I'll use the workaround method until the new release with your patch hits.

          Benjamin Hodgetts added a comment - Thanks Philipp. Correct, I have clear existing tags on (to remove any old cruft) and disabling that option (or adding the exclusion as you mentioned) both negate the problem. Thanks for getting on this so quickly, I'll use the workaround method until the new release with your patch hits.

          Philipp Wolfer added a comment -

          And to give you a workaround for existing Picard 2.0.3: Just add "waveformatextensible_channel_mask" to Options > Tags > "Preserve these tags from being cleared or overwritten..."

          Philipp Wolfer added a comment - And to give you a workaround for existing Picard 2.0.3: Just add "waveformatextensible_channel_mask" to Options > Tags > "Preserve these tags from being cleared or overwritten..."

          Philipp Wolfer added a comment - - edited

          Now that's a fun issue Turns out FLAC actually is storing the channel layout in the tags, namely a tag named WAVEFORMATEXTENSIBLE_CHANNEL_MASK . For "5.1" this takes the format "0x3f". But "5.1(side)" seems to be the default if the header is not present.

          Now if you enable "Clear existing tags" and save a FLAC file with this tag set it gets removed.

          I have submitted a patch to preserve this special tag when clearing existing tags:

          https://github.com/metabrainz/picard/pull/943/

          Important: I can only reproduce this if I have "Clear existing tags" enabled, and that's the case my patch is handling. Can you confirm you have this option checked and that this does not happen without "Clear existing tags"?

           

          Philipp Wolfer added a comment - - edited Now that's a fun issue Turns out FLAC actually is storing the channel layout in the tags, namely a tag named WAVEFORMATEXTENSIBLE_CHANNEL_MASK . For "5.1" this takes the format "0x3f". But "5.1(side)" seems to be the default if the header is not present. Now if you enable "Clear existing tags" and save a FLAC file with this tag set it gets removed. I have submitted a patch to preserve this special tag when clearing existing tags: https://github.com/metabrainz/picard/pull/943/ Important: I can only reproduce this if I have "Clear existing tags" enabled, and that's the case my patch is handling. Can you confirm you have this option checked and that this does not happen without "Clear existing tags"?  

            outsidecontext Philipp Wolfer
            enverex Benjamin Hodgetts
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.0.4