Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1402

macOS: Register for supported file types to open with Finder or drag and drop on dock icon

XMLWordPrintable

      Picard 2.0.4 is not accepting MP3 files dragged onto it's Dock or Finder icon.

      Files dragged into the app main window does still work.

          [PICARD-1402] macOS: Register for supported file types to open with Finder or drag and drop on dock icon

          Philipp Wolfer added a comment -

          https://github.com/metabrainz/picard/pull/1432

          Turns out this actually just requires the Picard app to register for supported files types. Without this declaration "open with" or drag and drop won't be supported by macOS. Will be in the next release.

          Philipp Wolfer added a comment - https://github.com/metabrainz/picard/pull/1432 Turns out this actually just requires the Picard app to register for supported files types. Without this declaration "open with" or drag and drop won't be supported by macOS. Will be in the next release.

          Philipp Wolfer added a comment -

          I did some research and testing. It looks like the implementation inside Picard still would be correct. It works when running Picard from source.

          The reason why it is broken in the package seems to be this pyinstaller issue: https://github.com/pyinstaller/pyinstaller/issues/1309

          It is a very old issue, but just recently there was some progress with a pull request presented. I have not yet tested this patch to pyinstaller but if this gets accepted we could have a solution soon. And if not we should maybe think about using a custom patched pyinstaller.

          Philipp Wolfer added a comment - I did some research and testing. It looks like the implementation inside Picard still would be correct. It works when running Picard from source. The reason why it is broken in the package seems to be this pyinstaller issue: https://github.com/pyinstaller/pyinstaller/issues/1309 It is a very old issue, but just recently there was some progress with a pull request presented. I have not yet tested this patch to pyinstaller but if this gets accepted we could have a solution soon. And if not we should maybe think about using a custom patched pyinstaller.

          Philipp Wolfer added a comment - - edited

          Marked it as a bug since this is actually a regression. It was originally implemented in https://github.com/metabrainz/picard/commit/e5d4a5a77cf8ef54604db43c2a09a4fa68f5af84 . Probably the move to PyQt5 broke it.

          And probably will require the same fix as PICARD-1035

          EDIT: PICARD-1035 was reported to be broken for Picard 1.4 also, so if it has the same root cause it might not be the Qt5 change. Also the other ticket mentions some packaging issue.

          Philipp Wolfer added a comment - - edited Marked it as a bug since this is actually a regression. It was originally implemented in https://github.com/metabrainz/picard/commit/e5d4a5a77cf8ef54604db43c2a09a4fa68f5af84 . Probably the move to PyQt5 broke it. And probably will require the same fix as PICARD-1035 EDIT: PICARD-1035 was reported to be broken for Picard 1.4 also, so if it has the same root cause it might not be the Qt5 change. Also the other ticket mentions some packaging issue.

            outsidecontext Philipp Wolfer
            cyberskull Trevor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.3.0b1