Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1416

Should store ID3 Artists field as TXXX:ARTISTS not TXXX:Artists

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.1
    • 2.0.4
    • Tags & Metadata
    • None

      From https://docs.google.com/spreadsheets/d/1afugW3R1FRDN-mwt5SQLY4R7aLAu3RqzjN3pR1497Ok/edit?usp=sharing I see that Picard now support the Artists  field for storing multiple artists, and i think this is fairly recent that it is part of the standard build ?

      I request that for ID3 it is changed from TXXX:Artists to TXXX:ARTISTS for two reasons

      1.This was first added by Jaikoz/SongKong and it should always be preferred to use the existing method when one already exists as I have always strived to do.

      2. Tools that convert files from one format to another deal with custom metadata quite simply. So for example if a WAV file was converted with popular dbPoweramp to Flac TXXX:Artists would become Artists, whereas in your mapping you want it to become ARTISTS (i.e UPPERCASE). Whereas if you used my solution TXXX:ARTISTS would be correctly converted to _ARTISTS  _and vice versa. The sentence case used in ID3 by many MusicBrainz fields has no logical advantage and this very real disadvantage. So since artists fields has not been in PIcard for that long I ask that you rename it.

          [PICARD-1416] Should store ID3 Artists field as TXXX:ARTISTS not TXXX:Artists

          Philipp Wolfer added a comment - https://github.com/metabrainz/picard/pull/1043

          Paul Taylor added a comment - - edited

          As per the issue description, converting from one format to another causes custom fields to not be converted correctly for the new format.

          Paul Taylor added a comment - - edited As per the issue description, converting from one format to another causes custom fields to not be converted correctly for the new format.

          What is " the dbPoweramp problem"?

          Philipp Wolfer added a comment - What is " the dbPoweramp problem"?

          Paul Taylor added a comment -

          Ah sorry. I think it was originally Artists then changed to ARTISTS when I became aware of the dbPoweramp problem, I was not aware that Picard was using it then, and that tagmpping file is out of date, going forward please always consults the Picard/SongKong google spreadsheet (and double check by looking at  the jaudiotagger source code)

          Paul Taylor added a comment - Ah sorry. I think it was originally Artists then changed to ARTISTS when I became aware of the dbPoweramp problem, I was not aware that Picard was using it then, and that tagmpping file is out of date, going forward please always consults the Picard/SongKong google spreadsheet (and double check by looking at  the jaudiotagger source code)

          Paul, can you confirm it is ARTISTS for jaudiotagger?

          On http://www.jthink.net/jaudiotagger/tagmapping.html it is listed as "Artists", that's maybe where this confusion started.

          Philipp Wolfer added a comment - Paul, can you confirm it is ARTISTS for jaudiotagger? On http://www.jthink.net/jaudiotagger/tagmapping.html it is listed as "Artists", that's maybe where this confusion started.

          Philipp Wolfer added a comment - - edited

          Fairly recent is relative, 5 years roughly

          But I agree itshoulf be fixed. Actually this was added with the comment "add jaikoz artists tag" in https://github.com/metabrainz/picard/commit/f144dde30df1db4f761d3e547bb50a5dc48d2722

          Philipp Wolfer added a comment - - edited Fairly recent is relative, 5 years roughly But I agree itshoulf be fixed. Actually this was added with the comment "add jaikoz artists tag" in https://github.com/metabrainz/picard/commit/f144dde30df1db4f761d3e547bb50a5dc48d2722

          Paul Taylor added a comment -

          Hi, yes it is similar and you'll see your tickets refers to another one by me - PICARD-1049

          However I don't think its currently practible to change all fields to UPPERCASE that would cause massive problems with other software, so Im only asking about the TXXX:Artists field since I think only Picard uses it, and it is based on the Jaikoz/SongKong one that I added. I;m not aware of any other tool that has inbuilt support for it, although of course users can configure various tools to use it.

          Paul Taylor added a comment - Hi, yes it is similar and you'll see your tickets refers to another one by me - PICARD-1049 However I don't think its currently practible to change all fields to UPPERCASE that would cause massive problems with other software, so Im only asking about the TXXX:Artists field since I think only Picard uses it, and it is based on the Jaikoz/SongKong one that I added. I;m not aware of any other tool that has inbuilt support for it, although of course users can configure various tools to use it.

          Peter Culak added a comment -

          Hi, is your suggestion similar to the one I had in https://tickets.metabrainz.org/browse/PICARD-1101 ? In there I was talking about changing every Picard tag from mixed case to all caps to ensure consistency with other taggers/media players, but I have no idea whether some of the tags in question are in fact the same (e.g. Artists vs TXXX:Artists). Additionally, should tags like "TXXX:MusicBrainz Artist Id" be changed into "TXXX:MUSICBRAINZ ARTIST ID" as well?

          Peter Culak added a comment - Hi, is your suggestion similar to the one I had in https://tickets.metabrainz.org/browse/PICARD-1101 ? In there I was talking about changing every Picard tag from mixed case to all caps to ensure consistency with other taggers/media players, but I have no idea whether some of the tags in question are in fact the same (e.g. Artists vs TXXX:Artists). Additionally, should tags like "TXXX:MusicBrainz Artist Id" be changed into "TXXX:MUSICBRAINZ ARTIST ID" as well?

            outsidecontext Philipp Wolfer
            ijabz Paul Taylor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.1