Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1804

Investigate if lower casing and decamelizing attributes is necessary

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • Tags & Metadata
    • None

      Currently Picard lower cases and decamalizes attribute values for relationships, see e.g. PICARD-1803.

      Investigate if this is actually necessary and remove the relevant code if not. Especially instrument names probably should be used as is.

          [PICARD-1804] Investigate if lower casing and decamelizing attributes is necessary

          Philipp Wolfer added a comment -

          No longer needed. Will be removed as part of fixing PICARD-1961

          Philipp Wolfer added a comment - No longer needed. Will be removed as part of fixing PICARD-1961

          Philipp Wolfer added a comment -

          This was added in https://github.com/metabrainz/picard/commit/d923c9a5f4d3f3f11e12d57e6e721e81d6f94938 specifically to parse camel cased instrument names. Since then instruments have completely changed and are proper names, with intentional upper and lower case spellings, e.g. "Wurlitzer electric piano"

          Philipp Wolfer added a comment - This was added in https://github.com/metabrainz/picard/commit/d923c9a5f4d3f3f11e12d57e6e721e81d6f94938 specifically to parse camel cased instrument names. Since then instruments have completely changed and are proper names, with intentional upper and lower case spellings, e.g. "Wurlitzer electric piano"

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package