Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1864

Adding single files does ignore existing MBIDs

XMLWordPrintable

      With version 2.4.0b1 when adding single files which already contain MBIDs the corresponding release does not get loaded if "‘Ignore MBIDs when loading new files" is unchecked.

      It works if you add a folder.

          [PICARD-1864] Adding single files does ignore existing MBIDs

          GitHub Bot added a comment -

          See code changes in pull request #1575 submitted by Gabrielcarvfer.

          GitHub Bot added a comment - See code changes in pull request #1575 submitted by Gabrielcarvfer .

          Gabriel Ferreira added a comment - - edited

          I didn’t manage to reproduce the MBID issue. 

          Tried loading folders and files with the setting disabled, then tried again with it enabled, then tried changing the setting while loading and all of them worked as expected. Not sure if I missed something.

          The changes made to speed up reading the settings could cause this kind of error, but I’ve debugged line by line and didn’t catch anything wrong.

          Based on the testing, I think it is more likely to be either file errors, duplicates that doesn't get loaded or invalid MBIDs.
          Edit: trying to use the file browser exposed the issue.

          Gabriel Ferreira added a comment - - edited I didn’t manage to reproduce the MBID issue.  Tried loading folders and files with the setting disabled, then tried again with it enabled, then tried changing the setting while loading and all of them worked as expected. Not sure if I missed something. The changes made to speed up reading the settings could cause this kind of error, but I’ve debugged line by line and didn’t catch anything wrong. Based on the testing, I think it is more likely to be either file errors, duplicates that doesn't get loaded or invalid MBIDs. Edit: trying to use the file browser exposed the issue.

            gabrielcarvfer Gabriel Ferreira
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                2.4.0b2