Normal It used to be possible to edit/remove and save tags in files listed in the left side pane in v2.3.2 (just tested it again on a different computer), but since the v2.4.1 upgrade, this no longer works. It displays a no-entry sign next to files when saving. It does remember the changes once the files are linked to releases and in the right hand side panel (unless the data is replaced with information from the release) and saves/removes the tags correctly, even though the files continue to display the no-entry sign (when linked to a release) until it's saved.
[PICARD-1918] Saving files fails if there is no front image and "Save only one front image as separate file" is enabled
I'm officially impressed. Thanks!
I checked the MP3 files and the embedded image type is set to "none".
Attached are my settings.
I was able to reproduce this. For this to happen you'll need either a file (e.g. MP3) with embedded images, but none set to be the front; or you could also reproduce it with a release from MB which has cover art but none set to front.
You'll also need to have the option "Save only one front image as separate file" activated in Options > Cover Art > Cover Art Archive.
Then saving will cause this error, as it tries to save the single front image, but this does not exist and is `None`
Fix in https://github.com/metabrainz/picard/pull/1613
Also this shows that this option is really placed wrongly (it is not a Cover Art Archive option, but it is presented as one) and behaves oddly. See my comment on the PR, I think we'll refactor this.
Thanks for the log. This is very odd, it fails somewhere in saving the cover art. Can you share your activated cover art sources and your cover art settings in Options > Cover Art and Options > Cover Art > Cover Art Archive ?
So I encountered this problem again, luckily I had verbosity set to "debug". The log shows the following when I try to save the file in the left pane of v2.4.2:
D: 17:10:36,866 formats.id3._save:371: Saving file 'M:
Music - Classical & Opera
L
Luciano Pavarotti
Highlights from the Grammy Album Volume 1
*07 - O sole mio - Torna a surriento - Nessum dorma.mp3*'
D: 17:10:36,872 file.update:635: Updating file <MP3File '06 - La favola dello zar saltan_ Il volo del carbrone.mp3'>
D: 17:10:37,065 file._save_and_rename:336: Not removing empty directory: M:\Music - Classical & Opera\L\Luciano Pavarotti\Highlights from the Grammy Album Volume 1 is not empty
E: 17:10:37,066 util.thread.run:64: Traceback (most recent call last):
File "picard\util\thread.py", line 60, in run
File "picard\file.py", line 339, in _save_and_rename
File "picard\file.py", line 504, in _save_images
AttributeError: 'NoneType' object has no attribute 'save'
D: 17:10:37,070 file.update:635: Updating file <MP3File '07 - O sole mio - Torna a surriento - Nessum dorma.mp3'>
I noticed that it is referring to the previous file in the middle - and this pattern is the same for all of the files on the album.
Again I tried to save the very same files in v2.3.2 and it worked fine:
D: 17:09:12,433 file.update:623: Updating file <MP3File '07 - O sole mio - Torna a surriento - Nessum dorma.mp3'>
The red error icon indicates something went wrong when saving the file. Please look at the output in Help > View Error/Debug log, it should provide more details.
Typical causes are the files or their parent folders being read-only, hidden or otherwise write protected or are in access by another application.
So this thing is merged and the bug itself fixed with this. Thanks a lot for reporting this and providing the details. This is one of the hard to find special cases