Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1931

Regression: "Unmatched Files" do not appear when release was deleted from MB

XMLWordPrintable

      I try to re-tag a file tagged previously as recording in the release.

      The release has been deleted from MB since then, the recording still exists.

      With Picard 2.3 I get the "could not load album $MBID" message with the "Unmatched files" subsection (where my file appears). I can drag my file to the left side, run the acoustID matching, and the MB recording appears as a "non-album track".

      With Picard 2.4 / 2.4.2 I get the "could not load album $MBID" message but no "Unmatched files" subsection. So my file appears nowhere and I have no way to retag it.

       

       

        1. picard2.3.2.png
          picard2.3.2.png
          21 kB
        2. picard2.4.png
          picard2.4.png
          15 kB

          [PICARD-1931] Regression: "Unmatched Files" do not appear when release was deleted from MB

          loujin added a comment -

          I can confirm the current master branch fixes the problem for me

          loujin added a comment - I can confirm the current master branch fixes the problem for me

          Philipp Wolfer added a comment -

          Thanks a lot for the detailed report. A proposed fix for this is in https://github.com/metabrainz/picard/pull/1615

          Philipp Wolfer added a comment - Thanks a lot for the detailed report. A proposed fix for this is in https://github.com/metabrainz/picard/pull/1615

          GitHub Bot added a comment -

          See code changes in pull request #1615 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #1615 submitted by phw .

          loujin added a comment -

          $ git bisect bad

          fac2b37d8cf8dad8e821de541b9c40ee2ae0a0b8 is the first bad commit
          commit fac2b37d8cf8dad8e821de541b9c40ee2ae0a0b8
          Author: Gabriel Ferreira <gabrielcarvfer@gmail.com>
          Date: Thu Jun 11 23:39:13 2020 -0300

          Postpone file moves until tracks have been loaded

          picard/tagger.py | 2 +-
          1 file changed, 1 insertion, 1 deletion

          loujin added a comment - $ git bisect bad fac2b37d8cf8dad8e821de541b9c40ee2ae0a0b8 is the first bad commit commit fac2b37d8cf8dad8e821de541b9c40ee2ae0a0b8 Author: Gabriel Ferreira <gabrielcarvfer@gmail.com> Date: Thu Jun 11 23:39:13 2020 -0300 Postpone file moves until tracks have been loaded picard/tagger.py | 2 +- 1 file changed, 1 insertion , 1 deletion

            outsidecontext Philipp Wolfer
            loujin loujin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                2.4.3
                2.4.4