Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1939

Crash when "Remove" button is hit without picking a file first

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.5.0b1
    • 2.4.4
    • User Interface
    • None
    • Win 10 x64

      1. Launch program.
      2. Drag directory of MP3s into left pane.
      3. Cluster as usual
      4. Pick that cluster, and lookup or scan, doesn't matter, jut needs to end up in the right pane.
      5. If you now press the red REMOVE (X) Icon without selecting any file or grouping in the right pane (or inadvertently anywhere else in the left pane), the program will abruptly terminate.

      So the remove button should probably be disabled until it's primed with a selected target to remove.

          [PICARD-1939] Crash when "Remove" button is hit without picking a file first

          GitHub Bot added a comment -

          See code changes in pull request #1622 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #1622 submitted by phw .

          Thanks for reporting this. Yes, the button is supposed to be disabled but the selection change is not updated correctly in this case. I think this is a regression from the changes to even handling in 2.4.

          Philipp Wolfer added a comment - Thanks for reporting this. Yes, the button is supposed to be disabled but the selection change is not updated correctly in this case. I think this is a regression from the changes to even handling in 2.4.

            outsidecontext Philipp Wolfer
            rip1980 Kevin V
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                2.5.0b1