Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2058

Add File dialog does not show files with uppercase extension on case-sensitive file systems

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.5.3
    • 2.5.2
    • User Interface
    • None

      On case-sensitive file systems the Add File dialog does not show files with matching extension, if it is uppercase (e.g. test.MP3).

          [PICARD-2058] Add File dialog does not show files with uppercase extension on case-sensitive file systems

          GitHub Bot added a comment -

          See code changes in pull request #1708 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #1708 submitted by phw .

          Philipp Wolfer added a comment -

          This is a bit annoying to solve:

          • The file extensions given to QFileDialog as filters are always considered case sensitive if the file system is case sensitive.
          • The alternative would be setting mime type filters, but actually they are just a wrapper around file extension filters and suffer from the same problem (only consider lower case extension)
          • The obvious solution is to list both lower and uppercase variants of the extensions in the filters. This works (except for mixed case extensions, but let's ignore those as they are not that common). But at least on Windows native dialog it is annoying, because all extensions are listed in the file filter dropdown. On the GTK file picker it looks ok (only the names are listed), other dialogs I have not tested.

          See also https://stackoverflow.com/questions/34858220/qt-how-to-set-a-case-insensitive-filter-on-qfiledialog

          So maybe we need to only have lower / upper case variants if the OS usually is case sensitive.

          Philipp Wolfer added a comment - This is a bit annoying to solve: The file extensions given to QFileDialog as filters are always considered case sensitive if the file system is case sensitive. The alternative would be setting mime type filters, but actually they are just a wrapper around file extension filters and suffer from the same problem (only consider lower case extension) The obvious solution is to list both lower and uppercase variants of the extensions in the filters. This works (except for mixed case extensions, but let's ignore those as they are not that common). But at least on Windows native dialog it is annoying, because all extensions are listed in the file filter dropdown. On the GTK file picker it looks ok (only the names are listed), other dialogs I have not tested. See also https://stackoverflow.com/questions/34858220/qt-how-to-set-a-case-insensitive-filter-on-qfiledialog So maybe we need to only have lower / upper case variants if the OS usually is case sensitive.

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                2.5.3