Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2172

Using "Use original values" on a large number of recordings will skyrocket memory usage

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • 2.6.0b3
    • Tags & Metadata
    • None
    • Windows 10 Home Build 19042, Picard 2.6.0b3

      Yesterday I wanted to add the new original release dates for recordings to all my music. After running the script, I first ran the "remove perfect albums" plugin, which took about 2 hours and resulted in 6GB memory usage. Afterwards I used "use original values" for titles, on every recording. I don't know how long this took but I had to keep it running overnight. Picard's memory usage is now over 20GB (see attachment).

          [PICARD-2172] Using "Use original values" on a large number of recordings will skyrocket memory usage

          Mark Bakker added a comment -

          the memory usage has been fine on my end. but (this might be semi-related) when you select all recordings or releases, and do some large action such as "remove all perfect albums" or "use original values", then just let it do its thing it will be very slow, but if you click somewhere where it will unselect the recordings/releases it will process much faster. it seems like its updating the view and maybe processing all tags after each step, and if you unselect them it wont do that

          Mark Bakker added a comment - the memory usage has been fine on my end. but (this might be semi-related) when you select all recordings or releases, and do some large action such as "remove all perfect albums" or "use original values", then just let it do its thing it will be very slow, but if you click somewhere where it will unselect the recordings/releases it will process much faster. it seems like its updating the view and maybe processing all tags after each step, and if you unselect them it wont do that

          Yes, I downgraded it. This has been flagged as high for years, but without any reports on this elsewhere, me not able to reproduce and nobody working on it. Not what I would call high priority really.

          Philipp Wolfer added a comment - Yes, I downgraded it. This has been flagged as high for years, but without any reports on this elsewhere, me not able to reproduce and nobody working on it. Not what I would call high priority really.

          Tenome added a comment -

          Downgraded to "Normal" priority, eh. Is this still an issue with the latest build of Picard? I haven't tried something like this again since.

          Tenome added a comment - Downgraded to "Normal" priority, eh. Is this still an issue with the latest build of Picard? I haven't tried something like this again since.

          It could be worth to try with memray. It can apparently catch c++ allocations too, so even Qt leaks could get caught.

           

          https://bloomberg.github.io/memray/getting_started.html

          Gabriel Ferreira added a comment - It could be worth to try with memray. It can apparently catch c++ allocations too, so even Qt leaks could get caught.   https://bloomberg.github.io/memray/getting_started.html

          Tenome added a comment - - edited

          I just had this happen to me while I was about to tag about 1000 albums, causing Picard to crash and lose a bunch of progress. Lesson learned I guess, hit Ctrl-S more often and do smaller batches. 16gb RAM.

          Tenome added a comment - - edited I just had this happen to me while I was about to tag about 1000 albums, causing Picard to crash and lose a bunch of progress. Lesson learned I guess, hit Ctrl-S more often and do smaller batches. 16gb RAM.

          cam1170 added a comment - - edited

          Sorry, wrong issue

          cam1170 added a comment - - edited Sorry, wrong issue

          cam1170 added a comment -

          Duplicate of PICARD-2370

          cam1170 added a comment - Duplicate of PICARD-2370

          Mark Bakker added a comment -

          With the normal 2.6 build, constantly selecting and deselecting 8000 files/2000 albums only makes memory go up by 7MB every time, on my machine. It does go down occassionally but only by a little and above the starting memory

          Mark Bakker added a comment - With the normal 2.6 build, constantly selecting and deselecting 8000 files/2000 albums only makes memory go up by 7MB every time, on my machine. It does go down occassionally but only by a little and above the starting memory

          I only tested this with unmatched files so far, by loading the files with "Ignore existing MBIDs" activated. That way loading goes reasonable fast, but of course only tests a specific case.

          Philipp Wolfer added a comment - I only tested this with unmatched files so far, by loading the files with "Ignore existing MBIDs" activated. That way loading goes reasonable fast, but of course only tests a specific case.

          Mark Bakker added a comment -

          is there a way to test this without waiting for 1000s of albums to load from MB?

          Mark Bakker added a comment - is there a way to test this without waiting for 1000s of albums to load from MB?

            Unassigned Unassigned
            Xythium Mark Bakker
            Votes:
            3 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:

                Version Package