Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2256

Scripting is broken with AcousticBrainz Tags

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • 2.6.3
    • None
    • Win 7

      Using AcousticBrainz Tags plugin (2.1), scripts which use at least one of its tags don't work as expected.

      For example, an script with

      $noop(ISMIR2004 Rhythm Classification Dataset "Ballroom dataset")
      $unset(ab:hi:ismir04_rhythm:chachacha)
      $unset(ab:hi:ismir04_rhythm:jive)
      $unset(ab:hi:ismir04_rhythm:quickstep)
      $unset(ab:hi:ismir04_rhythm:rumba-american)
      $unset(ab:hi:ismir04_rhythm:rumba-international)
      $unset(ab:hi:ismir04_rhythm:rumba-misc)
      $unset(ab:hi:ismir04_rhythm:samba)
      $unset(ab:hi:ismir04_rhythm:tango)
      $unset(ab:hi:ismir04_rhythm:viennesewaltz)
      $unset(ab:hi:ismir04_rhythm:waltz)

      Should delete those tags when High level tags are enabled (and obviously the script too).

      Contrary to what I would expect, it never gets applied (it's like those tags doesn't exist yet when the script runs after loading the release). Manually re-applying the script does work (see gif 2).

      Similarly, using the high level tags to set some values results in the same errors. None can be used! (see gif 2)

       

      $noop(Timbre tags: timbre -label-)
      $set(timbre,‎$if($gte($substr(%ab:hi:timbre:bright%,2,3),5),Bright,Dark))
      

       

      Tried another script to merge last fm moods with the "moods" tags by the plugin, and it doesn't work. Again.. because the moods tags provided by the plugin seems to be applied after the scripts run, therefore the merging is overwritten with whatever the plugin outputs.

       

      $copymerge(mood,moodnew)
      $delete(moodnew)
      

       

       

      As can be seen at the gifs, the scripts work fine once the release is fully loaded and using then manually (see gif 2). But they are broken when applied automatically (see gif 1).

        1. picard1.gif
          picard1.gif
          1.65 MB
        2. picard2.gif
          picard2.gif
          1019 kB

          [PICARD-2256] Scripting is broken with AcousticBrainz Tags

          Thanks a lot for reporting. Indeed the script applied the data after the album was fully loaded.

          This has been reworked in https://github.com/metabrainz/picard-plugins/commit/110cbf67c7312e9057aabb2b923fbd78ce01ae74 . The updated plugin version 2.2 will be available in a few hours via update.

          Philipp Wolfer added a comment - Thanks a lot for reporting. Indeed the script applied the data after the album was fully loaded. This has been reworked in https://github.com/metabrainz/picard-plugins/commit/110cbf67c7312e9057aabb2b923fbd78ce01ae74 . The updated plugin version 2.2 will be available in a few hours via update.

          Isabelxxx added a comment -

          Would want to add that the old plugin AcousticBrainz Mood-Genre by Andrew Cook, Sambhav Kothar, worked fine with scripting. In fact the mood merging script worked right with it... the problem has appeared with the new plugin only.

          Isabelxxx added a comment - Would want to add that the old plugin AcousticBrainz Mood-Genre by Andrew Cook, Sambhav Kothar, worked fine with scripting. In fact the mood merging script worked right with it... the problem has appeared with the new plugin only.

            outsidecontext Philipp Wolfer
            Isabelxxx Isabelxxx
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package