Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2539

Picard crashes on huge releases if no cover art provider is active

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: High High
    • 2.8.4
    • 2.8.3
    • None
    • None
    • Linux (Fedora 36) @ x86_64, picard 2.8.3 (the last released version), all plugins are disabled.

      Attempt to tag a huge release, like 30-CDs The Complete Elvis Presley Masters causes Picard interface to freeze. The system shows the dialog "The MusicBarinz Picard is not responding". That's not a big deal, but Picard prints error to the terminal window:

      Traceback (most recent call last):
      File "/usr/lib64/python3.10/site-packages/picard/webservice/__init__.py", line 572, in _process_reply
          self._handle_reply(reply, request)
        File "/usr/lib64/python3.10/site-packages/picard/webservice/__init__.py", line 559, in _handle_reply
          handler(document, reply, error)
        File "/usr/lib64/python3.10/site-packages/picard/album.py", line 357, in _recordings_request_finished
          self._finalize_loading(error)
        File "/usr/lib64/python3.10/site-packages/picard/album.py", line 547, in _finalize_loading
          self._finalize_loading_album()
        File "/usr/lib64/python3.10/site-packages/picard/album.py", line 476, in _finalize_loading_album
          for track in self._new_tracks:
      AttributeError: 'Album' object has no attribute '_new_tracks'. Did you mean: '_load_tracks'?
      

      Some times later Picard starts to respond. I am not sure all the information is loaded correctly. If I press Ctrl+R to refresh the release, Picard prints the same stack trace and error again, and crashes:

      Traceback (most recent call last):
        File "/usr/lib64/python3.10/site-packages/picard/webservice/__init__.py", line 572, in _process_reply
          self._handle_reply(reply, request)
        File "/usr/lib64/python3.10/site-packages/picard/webservice/__init__.py", line 559, in _handle_reply
          handler(document, reply, error)
        File "/usr/lib64/python3.10/site-packages/picard/album.py", line 357, in _recordings_request_finished
          self._finalize_loading(error)
        File "/usr/lib64/python3.10/site-packages/picard/album.py", line 547, in _finalize_loading    self._finalize_loading_album()
        File "/usr/lib64/python3.10/site-packages/picard/album.py", line 476, in _finalize_loading_album
          for track in self._new_tracks:
      AttributeError: 'Album' object has no attribute '_new_tracks'. Did you mean: '_load_tracks'?
      Aborted (core dumped)
      

      See the attached picard.log.zip file for the complete Picard log and gdb.log for GDB dump of the core file.

      Another huge release, 40-CDs The Masterworks, also causes Picard to crash. Another huge release, 50-CDs The Original Elvis Presley Collection, also causes Picard crash.

      The previous Picard version, 2.8.2, behaves in the same way.

      I increased network timeout (Options → Advanced → Network → Request timeout in seconds) from 30 s to 100 s and didn't notice any change. Even 600 s din't help: Picard still crashes on huge releases.

      I tried to add not all tracks but only a small part of them, it didn't help either.

        1. picard.log.zip
          2.64 MB
        2. Picard.ini
          22 kB
        3. gdb.log
          39 kB

            outsidecontext Philipp Wolfer
            van.de.bugger Van de Bugger
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                2.8.4