Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2868

Picard crashes after selecting track search result

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.12
    • 2.11
    • None
    • None

      When loading the result for a track search Picard crashes.

      Steps to reproduce:

      1. In search toolbar select "track" and type "3 Bier"
      2. Select and load result for "3 Bier" by "Mehnersmoos" (https://musicbrainz.org/recording/c2813cfb-8be5-4d7f-baff-0d9cde2710bc)
      3. "Load in Picard"

      Attached debug log and config
      debug.log
      Picard.ini

        1. debug.log
          88 kB
        2. Picard.ini
          27 kB

          [PICARD-2868] Picard crashes after selecting track search result

          chaban added a comment -

          No more crash 👍
          As for why it silently crashes without leaving a trace in the logs I have no idea. Maybe it's related to Windows?

          chaban added a comment - No more crash 👍 As for why it silently crashes without leaving a trace in the logs I have no idea. Maybe it's related to Windows?

          Zas added a comment -

          I think I found the cause, but I still wonder about why it crashes for you, it would be great if you could test the fix on your platform to confirm.

          Zas added a comment - I think I found the cause, but I still wonder about why it crashes for you, it would be great if you could test the fix on your platform to confirm.

          GitHub Bot added a comment -

          See code changes in pull request #2416 submitted by zas.

          GitHub Bot added a comment - See code changes in pull request #2416 submitted by zas .

          Zas added a comment -

          Weird you get a crash, reproducing steps I get an exception (which might be the cause of the crash you get though):

          Traceback (most recent call last):
          File "/home/zas/src/picard/./picard/ui/tablebaseddialog.py", line 206, in accept
          self.accept_event(selected_rows_user_values)
          File "/home/zas/src/picard/./picard/ui/searchdialog/track.py", line 180, in accept_event
          self.load_selection(row)
          File "/home/zas/src/picard/./picard/ui/searchdialog/track.py", line 215, in load_selection
          self.tagger.move_file_to_nat(self.file_, track['musicbrainz_recordingid'], node)
          File "/home/zas/src/picard/./picard/tagger.py", line 712, in move_file_to_nat
          file.move(self.nats.unmatched_files)
          AttributeError: 'NoneType' object has no attribute 'move'

          Zas added a comment - Weird you get a crash, reproducing steps I get an exception (which might be the cause of the crash you get though): Traceback (most recent call last): File "/home/zas/src/picard/./picard/ui/tablebaseddialog.py", line 206, in accept self.accept_event(selected_rows_user_values) File "/home/zas/src/picard/./picard/ui/searchdialog/track.py", line 180, in accept_event self.load_selection(row) File "/home/zas/src/picard/./picard/ui/searchdialog/track.py", line 215, in load_selection self.tagger.move_file_to_nat(self.file_, track ['musicbrainz_recordingid'] , node) File "/home/zas/src/picard/./picard/tagger.py", line 712, in move_file_to_nat file.move(self.nats.unmatched_files) AttributeError: 'NoneType' object has no attribute 'move'

            zas Zas
            chaban chaban
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                2.12