Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2880

Non-integer rate limit delay causes crashes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.12
    • 2.11
    • None

      If a rate limit delay is set via ratecontrol.set_minimum_delay to a float value Picard crashes during networking. See the comment on PICARD-2742:

      D: 11:26:15,682 webservice/ratecontrol._out_of_backoff:231: ('musicbrainz.org', 443): oobackoff; delay: 1000ms -> 1000ms; slow start; window size 8.000 -> 9.000
      D: 11:26:15,686 webservice/ratecontrol.get_delay_to_next_request:130: ('orion.apiseeds.com', 443): Last request was 183 ms ago, waiting 117 ms before starting another one
      D: 11:26:15,686 webservice/ratecontrol.get_delay_to_next_request:130: ('musicbrainz.org', 443): Last request was 99 ms ago, waiting 901 ms before starting another one
      D: 11:26:15,806 webservice/ratecontrol.get_delay_to_next_request:127: ('orion.apiseeds.com', 443): Last request was 303 ms ago, starting another one
      D: 11:26:15,807 webservice/ratecontrol.increment_requests:147: ('orion.apiseeds.com', 443): Incrementing requests to: 3
      D: 11:26:15,807 webservice/ratecontrol.get_delay_to_next_request:130: ('musicbrainz.org', 443): Last request was 220 ms ago, waiting 780 ms before starting another one
      Traceback (most recent call last):
        File "webservice/_init_.py", line 717, in _run_next_task
      TypeError: arguments did not match any overloaded call:
        start(self, msec: int): argument 1 has unexpected type 'float'
        start(self): too many arguments

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                2.12