Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2931

Esc key should not terminate and discard Options window when unsaved changes are present

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • 2.11
    • User Interface
    • None
    • Windows 10

      If unsaved tagger script changes are in progress and the Esc key is pressed, the Options window closes and discards all work.  IMO, the Esc key should not do this.

      (Additionally, there's no way to apply/save tagger script changes without closing the Options window, which I don't think was the case prior to renaming the button to "Make It So!", but that might not be true.)

          [PICARD-2931] Esc key should not terminate and discard Options window when unsaved changes are present

          Philipp Wolfer added a comment -

          It could show a confirmation dialog when trying to close the option dialog with unsaved changes. That should then apply to all ways of cancelling the dialog.

          (Additionally, there's no way to apply/save tagger script changes without closing the Options window, which I don't think was the case prior to renaming the button to "Make It So!", but that might not be true.)

          Nothing has changed here. Configuration changes have always been applied only when saving the dialog, never directly when changing the options. And I think we should keep it that way to allow to cancel without saving the changes.

          We could maybe add an apply button. But then we should also rework the buttons as there are already a lot. Maybe we can combine the two reset options into one button or such.

          Philipp Wolfer added a comment - It could show a confirmation dialog when trying to close the option dialog with unsaved changes. That should then apply to all ways of cancelling the dialog. (Additionally, there's no way to apply/save tagger script changes without closing the Options window, which I don't think was the case prior to renaming the button to "Make It So!", but that might not be true.) Nothing has changed here. Configuration changes have always been applied only when saving the dialog, never directly when changing the options. And I think we should keep it that way to allow to cancel without saving the changes. We could maybe add an apply button. But then we should also rework the buttons as there are already a lot. Maybe we can combine the two reset options into one button or such.

            Unassigned Unassigned
            yindesu yindesu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package