Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-3043

Impossible to delete "performer" tag in ID3

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.13.4
    • 2.13.3
    • Tags & Metadata
    • None

      It is currently impossible to just delete a tag "performer" without role in ID3 tags.

      When saving a single tag "performer" to a file and later deleting the tag after saving it is still present. The deletion only handles tags with roles (e.g. performer:guitar).

      There is a test "test_delete_tags_with_empty_description" which is supposed to capture this case. But as it also ads a performer tag with role and both are stored in a single TMCL frame, the newly constructred TMCL frame does not contain "performer", which makes the test pass.

      1. Fix the issue
      2. Improve tests so they do test the isolated case of removing just the performer

       

          [PICARD-3043] Impossible to delete "performer" tag in ID3

          GitHub Bot added a comment -

          See code changes in pull request #2597 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #2597 submitted by phw .

            Unassigned Unassigned
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                2.13.4