Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-350

Picard downloads multiple 'front' images instead of just first one.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 1.4
    • 1.2
    • Cover Art
    • None

      I have picard set to download CAA images of type 'front', and save them to 'cover(.jpg)'. Ideally, it should download only the frontiest image and save it as cover.jpg. Instead, it downloads all images that are marked with type front, and saves them as 'cover.jpg', 'cover (1).jpg', etc.

      This happens with stuff like http://musicbrainz.org/release/bef90838-a09d-4853-ae85-6314d3ab5a4b/cover-art which has 4 images marked with type 'Front', but I only want the first one as an identifying image.

      This might require a bit of a UI change; wanting only the frontiest image is a bit different than filtering the wanted images by type.

          [PICARD-350] Picard downloads multiple 'front' images instead of just first one.

          Rahul Raturi added a comment -

          Forgot to mention the fix version.

          Rahul Raturi added a comment - Forgot to mention the fix version.

          Rahul Raturi added a comment -

          https://github.com/musicbrainz/picard/commit/d1d4d4daae7befce2fa331a2210cb41a6873042c

          Rahul Raturi added a comment - https://github.com/musicbrainz/picard/commit/d1d4d4daae7befce2fa331a2210cb41a6873042c

          Rahul Raturi added a comment -

          https://github.com/musicbrainz/picard/pull/455

          Rahul Raturi added a comment - https://github.com/musicbrainz/picard/pull/455

          Zas added a comment - - edited

          Rahul: feel free to work on such feature, and propose a patch. I don't have much time now to work on Picard anyway.

          Zas added a comment - - edited Rahul: feel free to work on such feature, and propose a patch. I don't have much time now to work on Picard anyway.

          Rahul Raturi added a comment -

          Zas: Can't we have an option similar to only embed a front image, to save single front image to directory (if the user has set to download only front image, not back or spine or something else). It would not complicate things much and I think is sufficient for normal user.

          We can put this option, along with the file name, and overwrite option in a separate window (like the select type option in CAA setting). More options can be added there for advanced users like you said above (max images).

          I can work on this if you approve.

          Rahul Raturi added a comment - Zas: Can't we have an option similar to only embed a front image , to save single front image to directory (if the user has set to download only front image, not back or spine or something else). It would not complicate things much and I think is sufficient for normal user. We can put this option, along with the file name, and overwrite option in a separate window (like the select type option in CAA setting). More options can be added there for advanced users like you said above (max images). I can work on this if you approve.

          Richard Kraft added a comment -

          +1, annoying esp. if you are going through a huge collection.

          Richard Kraft added a comment - +1, annoying esp. if you are going through a huge collection.

          Zas added a comment -

          We have an option to save only one front image to tags, but not one to save only one front image to directory.

          I'm thinking about allowing to set max number of images to save to tags and to directory per type (together with an absolute maximum for any type):
          Save max 1 front image, 1 back, to tags (2 max total)
          Save max 1 front, 1 back, 1 spine, unlimited booklet, 0 medium, to directory (unlimited max total)
          And add image size limit (or resizing)

          It looks overcomplicated for the average user, but needed to fit all needs.

          Zas added a comment - We have an option to save only one front image to tags, but not one to save only one front image to directory. I'm thinking about allowing to set max number of images to save to tags and to directory per type (together with an absolute maximum for any type): Save max 1 front image, 1 back, to tags (2 max total) Save max 1 front, 1 back, 1 spine, unlimited booklet, 0 medium, to directory (unlimited max total) And add image size limit (or resizing) It looks overcomplicated for the average user, but needed to fit all needs.

          Zas added a comment -

          https://github.com/musicbrainz/picard/pull/116
          https://github.com/musicbrainz/picard/pull/333

          Fix isn't complete since more than one front image can be downloaded, even if not needed.
          Also option should be renamed.

          Zas added a comment - https://github.com/musicbrainz/picard/pull/116 https://github.com/musicbrainz/picard/pull/333 Fix isn't complete since more than one front image can be downloaded, even if not needed. Also option should be renamed.

            rahulr Rahul Raturi
            kepstin Calvin Walton
            Votes:
            3 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                1.4