Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-50

Picard not applying "convert unicode punctuation to ascii" setting to album-level metadata

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 0.16
    • 0.15, 0.15.1
    • Tags & Metadata
    • None

      See http://forums.musicbrainz.org/viewtopic.php?pid=15524

      At first glance it looks to me like album.py:_parse_release() needs a call just after line 95 like

      # Convert Unicode punctuation
if self.config.setting['convert_punctuation']:
    m.apply_func(asciipunct)

      There is the wider issue of the weird behaviour you get due to some things reading metadata from the album object, but some from the track object, but that may be a separate ticket...

          [PICARD-50] Picard not applying "convert unicode punctuation to ascii" setting to album-level metadata

          Michael Wiencek added a comment -

          Okay, sounds good, they can always be revisited for the 1.0 release.

          Michael Wiencek added a comment - Okay, sounds good, they can always be revisited for the 1.0 release.

          voiceinsideyou added a comment - - edited

          Yeah; decided to sort out the rest of PICARD-54 last night in the end. None of the other fixes were critical, or had much real progress made on them, so no big deal

          voiceinsideyou added a comment - - edited Yeah; decided to sort out the rest of PICARD-54 last night in the end. None of the other fixes were critical, or had much real progress made on them, so no big deal

          Michael Wiencek added a comment -

          Ah, well nice to see that you have a pull request for PICARD-54 at least. What were the other fixes you were working on? I can help take a look at one or two of them, but I guess it depends on the complexity of the ticket if they can be fixed in time.

          Michael Wiencek added a comment - Ah, well nice to see that you have a pull request for PICARD-54 at least. What were the other fixes you were working on? I can help take a look at one or two of them, but I guess it depends on the complexity of the ticket if they can be fixed in time.

          voiceinsideyou added a comment -

          Argh; not much chance of me being done for that

          voiceinsideyou added a comment - Argh; not much chance of me being done for that

          nikki added a comment -

          voiceinsideyou: luks and bitmap were planning a release of some sort this weekend - http://chatlogs.musicbrainz.org/musicbrainz-devel/2011/2011-10/2011-10-17.html#T19-39-24-891751

          nikki added a comment - voiceinsideyou: luks and bitmap were planning a release of some sort this weekend - http://chatlogs.musicbrainz.org/musicbrainz-devel/2011/2011-10/2011-10-17.html#T19-39-24-891751

          voiceinsideyou added a comment -

          Awesome; good to have someone taking a critical look at some of these long-standing weirdnesses!

          is there a current vague aim for timing of 0.16 release? I'd really like to get a couple of fixes in - especially PICARD-54 which is a regression in 0.13 onwards - perhaps I need a bit of time pressure to kick me in the butt?

          voiceinsideyou added a comment - Awesome; good to have someone taking a critical look at some of these long-standing weirdnesses! is there a current vague aim for timing of 0.16 release? I'd really like to get a couple of fixes in - especially PICARD-54 which is a regression in 0.13 onwards - perhaps I need a bit of time pressure to kick me in the butt?

          Michael Wiencek added a comment -

          Don't worry, I tested the fix first and it solved the issue.

          There was actually another underlying cause here which I realized I fixed in an unrelated commit. I verified that when the "Details..." window opens, it's indeed consistently reading everything from track metadata. So I was confused why Album Artist and Album Artist Sort would have non-ASCII characters in them, when asciipunct definitely ran on the metadata. The reason turned out to be that the album metadata was being re-copied into the track metadata (it did this as a hack, just in case the album metadata was modified by a plugin, we wanted to copy back the changes). Anyway, since commit 2b30ad3a769dd602875dbfb05f9ab127b2caff86 it no longer uses that hack (and with your above fix we probably never would've noticed anyway).

          So I'm fairly sure this specific issue is fixed, unless there's other weird behavior I didn't notice.

          Michael Wiencek added a comment - Don't worry, I tested the fix first and it solved the issue. There was actually another underlying cause here which I realized I fixed in an unrelated commit. I verified that when the "Details..." window opens, it's indeed consistently reading everything from track metadata. So I was confused why Album Artist and Album Artist Sort would have non-ASCII characters in them, when asciipunct definitely ran on the metadata. The reason turned out to be that the album metadata was being re-copied into the track metadata (it did this as a hack, just in case the album metadata was modified by a plugin, we wanted to copy back the changes). Anyway, since commit 2b30ad3a769dd602875dbfb05f9ab127b2caff86 it no longer uses that hack (and with your above fix we probably never would've noticed anyway). So I'm fairly sure this specific issue is fixed, unless there's other weird behavior I didn't notice.

          voiceinsideyou added a comment -

          Ahh, cool. I never actually tested that "fix" - it was just an off the cuff thought, so not sure if it has any side effects. I was also planning to do a bit of digging and see why the bug reports mentioned sometimes it was correct and sometimes not - it indicates that Picard is not consistent as to whether it reads the release artist from the track or the album entity internally?

          voiceinsideyou added a comment - Ahh, cool. I never actually tested that "fix" - it was just an off the cuff thought, so not sure if it has any side effects. I was also planning to do a bit of digging and see why the bug reports mentioned sometimes it was correct and sometimes not - it indicates that Picard is not consistent as to whether it reads the release artist from the track or the album entity internally?

          Michael Wiencek added a comment -

          Applied voiceinsideyou's fix in http://git.musicbrainz.org/gitweb/?p=picard.git;a=commitdiff;h=fce9d38cdc495cc265c2c59afdd5d58d52334918

          Michael Wiencek added a comment - Applied voiceinsideyou's fix in http://git.musicbrainz.org/gitweb/?p=picard.git;a=commitdiff;h=fce9d38cdc495cc265c2c59afdd5d58d52334918

            bitmap Michael Wiencek
            voiceinsideyou voiceinsideyou
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                0.16