Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-514

Option to load only audio tracks, i.e. not DVD-Video, CD-ROM tracks

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 1.4
    • 1.2
    • User Interface
    • None

      At present, when loading a release that contains video tracks, these appear in Picard as tracks just like the audio ones. This can be annoying, as it means the release remains silver (imperfect) unless you add files for the video content. It would be great if there were an option to load only the audio portion of a release into Picard, where there is a mixture of audio and video in a release.

          [PICARD-514] Option to load only audio tracks, i.e. not DVD-Video, CD-ROM tracks

          None of the recordings listed on the second disc at https://musicbrainz.org/release/15164758-7343-498b-b32c-dcdc9cd6a5fb is marked as a video, hence they don't get ignored by the "ignore video" option. Update the recordings and set them to video and this will work.

          Philipp Wolfer added a comment - None of the recordings listed on the second disc at https://musicbrainz.org/release/15164758-7343-498b-b32c-dcdc9cd6a5fb is marked as a video, hence they don't get ignored by the "ignore video" option. Update the recordings and set them to video and this will work.

          Hey folks. I've ignore video files enabled but am getting a silver disc for a release without it's DVD files. Is this different enough a situation that the prior solution doesn't work on it?

          Milkii Brewster added a comment - Hey folks. I've ignore video files enabled but am getting a silver disc for a release without it's DVD files. Is this different enough a situation that the prior solution doesn't work on it?

          Yes, I close it. I just wanted to give it some time for feedback, but I guess that's ok now. If anyone has anything regarding this functionality please open a new ticket

          Philipp Wolfer added a comment - Yes, I close it. I just wanted to give it some time for feedback, but I guess that's ok now. If anyone has anything regarding this functionality please open a new ticket

          Zas added a comment -

          @Philipp Wolfer : can this one be marked as fixed ?

          Zas added a comment - @Philipp Wolfer : can this one be marked as fixed ?

          Philipp Wolfer added a comment - - edited

          The code for this has been merged. It would be great if people who participated in this discussion could give the next daily builds which will include this functionality give it a try. Since this is, as most user interface changes, hard to get right for everybody I would like to know whether this solved the issue at hand for you or not. And if not, how it could be further improved.

          The daily builds should get updated sometime tomorrow and will be available for download on http://picard.musicbrainz.org/downloads/ .

          Philipp Wolfer added a comment - - edited The code for this has been merged. It would be great if people who participated in this discussion could give the next daily builds which will include this functionality give it a try. Since this is, as most user interface changes, hard to get right for everybody I would like to know whether this solved the issue at hand for you or not. And if not, how it could be further improved. The daily builds should get updated sometime tomorrow and will be available for download on http://picard.musicbrainz.org/downloads/ .

          Philipp Wolfer added a comment - Pull request submitted at https://github.com/musicbrainz/picard/pull/383

          lixobix added a comment -

          Thanks for all your work Philipp!

          lixobix added a comment - Thanks for all your work Philipp!

          Should now all be done, the code is in https://github.com/phw/picard/tree/ignore-special-tracks-for-completeness

          I will wait until https://github.com/musicbrainz/picard/pull/378 gets accepted before pushing this.

          Philipp Wolfer added a comment - Should now all be done, the code is in https://github.com/phw/picard/tree/ignore-special-tracks-for-completeness I will wait until https://github.com/musicbrainz/picard/pull/378 gets accepted before pushing this.

          Philipp Wolfer added a comment - - edited

          I have done some initial work on this in https://github.com/phw/picard/tree/ignore-special-tracks-for-completeness

          The changes currently are:

          • Add a new variable ~video for video tracks (as reported by the MB web service)
          • Add the option to select which tracks to ignore when determining the release completeness (currently video, data and silent tracks) and ignore those
          • Tracks not taken for release completeness are displayed in a lighter color than the rest

          On my todo list:

          • Have a look at the upcoming pregap implementation and add support for it (at a first look I think Picard won't load and display them at all without modification)
          • Add a $is_complete() tagger function

          Not on my list:

          • Select medium formats to ignore. My current assumption is that this is solved by the video track support in MB server, and until proven otherwise I don't want to add clutter to the options.

          Philipp Wolfer added a comment - - edited I have done some initial work on this in https://github.com/phw/picard/tree/ignore-special-tracks-for-completeness The changes currently are: Add a new variable ~video for video tracks (as reported by the MB web service) Add the option to select which tracks to ignore when determining the release completeness (currently video, data and silent tracks) and ignore those Tracks not taken for release completeness are displayed in a lighter color than the rest On my todo list: Have a look at the upcoming pregap implementation and add support for it (at a first look I think Picard won't load and display them at all without modification) Add a $is_complete() tagger function Not on my list: Select medium formats to ignore. My current assumption is that this is solved by the video track support in MB server, and until proven otherwise I don't want to add clutter to the options.

          lixobix added a comment -

          I'm pretty much in agreement with you Philipp. Excluded tracks should be greyed out, or something similar, and not counted for completeness, but files can still be attached to them and edited / saved as usual.

          A list of track types to exclude seems the best idea, with a check box for each type. The advantage of this would be that we could add any other types as required if we become aware of them.

          I'm in agreement with your list, except for [unknown], as this could contain unique audio. Regarding data tracks on a separate medium, I'm not sure what the issue is. If users want to count these, they can uncheck [data track]. No idea how pre-gap is going to be implemented, so unless that has been decided elsewhere, it can be dealt with later. Another type that may be worth adding, although I'm not sure if we cater for it, is other CD-ROM etc. media, such as a game or photo gallery. Are these even added in MB, or do they fall under [data track]?

          lixobix added a comment - I'm pretty much in agreement with you Philipp. Excluded tracks should be greyed out, or something similar, and not counted for completeness, but files can still be attached to them and edited / saved as usual. A list of track types to exclude seems the best idea, with a check box for each type. The advantage of this would be that we could add any other types as required if we become aware of them. I'm in agreement with your list, except for [unknown] , as this could contain unique audio. Regarding data tracks on a separate medium, I'm not sure what the issue is. If users want to count these, they can uncheck [data track] . No idea how pre-gap is going to be implemented, so unless that has been decided elsewhere, it can be dealt with later. Another type that may be worth adding, although I'm not sure if we cater for it, is other CD-ROM etc. media, such as a game or photo gallery. Are these even added in MB, or do they fall under [data track] ?

            outsidecontext Philipp Wolfer
            lixobix lixobix
            Votes:
            3 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                1.4