Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-566

setup.py build_ui incorrectly checks file dates

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None
    • Environment:
      Win 8.1 x64, Python 2.7.6, PyQt4 4.10.3

      Description

      In setup.py, the build_ui code checks for the respective dates for the x.ui and ui_x.py files to determine whether it should recompile. Unfortunately Git updates the timestamp of files every time it changes a file during a Checkout - so this is not a great way of deciding whether a recompile is necessary.

      Perhaps it would be better to recompile to a temp file, then compare the files (ignoring differences in the opening comments such as file path (which could have / or ) the compile date and pyqt version) and see if the code is different - and if it is copy the code over to the picard/ui directory to replace existing.

        Attachments

          Activity

            People

            • Assignee:
              zas Zas
              Reporter:
              sophist Sophist
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: