Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-661

Regression: Tagger script for cover art filename does not work anymore

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: High High
    • 1.3.1
    • 1.3
    • Cover Art, Scripting
    • None

      This used to work in Picard 1.2, but broke during the cover art refactoring.

      This is the commit that broke it:
      https://github.com/musicbrainz/picard/commit/5a2eee348484403bf10d0617ce4dff462db1ad2f

      Details:
      The old code in file.py used this to evaluate the script:
      image_filename = self._script_to_filename(image_filename, metadata)

      In the current code the metadata is still passed to Image._make_image_filename but it is not used there. Should be easily fixable, but requires some refactoring to not duplicate code from file.py in image.py

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                1.3.1