Support adding/removing albums to/from an MB collection.
There's already completely functional code for this in the "collections" branch, which I wrote for GSoC, so this ticket is mainly for tracking purposes.
There's also some heavy modifications I want to do to the code once MBS-3708 is added.
- depends on
-
MBS-3708 Support "inc=collections" on ws/2/release to get a list of the collections which a release is in
-
- Closed
-
[PICARD-84] MB collections management support
@flamingspinach:
Yes, sorry for the delay here. Your comment gave me the impetus to finally address this. I partially merged some of the work from my collections branch. In picard-git there's now a collections submenu when you right-click on one or more albums. You can add/remove albums from a collection in this way. It might seem clunky, but I can always improve it based on user feedback.
The feature I didn't merge is the collections viewer, which was a separate window you could open to view all of your collections, and move releases between them. I'm mainly upset with the performance it has for large collections, not only because of web service paging when requesting the releases, but also the QTreeWidget itself, which is slow, and a terrible UI to begin with, because it's not searchable/filterable (without a custom model). I'm starting to question the usefulness of such a tool in picard. I really think a nice JS-based collections viewer/manager belongs on the MB website, not as a slow/clunky desktop app.
I'm going to close this ticket since we now have the basic functionality ("adding/removing albums to/from an MB collection"), and would prefer that people open improvements as separate tickets.
https://github.com/musicbrainz/picard/commit/994eb75c5474d6ac35a92a99c29f61d32ca0e71c
I've no depth to how your collections feature works (haven't tried it), though I came across this [1] and figured it might be useful for inspiration.
Correct, and the good news is that I already did the work to take advantage of MBS-3708. There remain a few bugs though, so I'm trying to find enough time to fix them. :/
Another change I made is that the collections viewer opens in a new window. I realized that adding another panel just looked ridiculous and overcrowded.
I've been putting this off for a while, so I plan on completing this entirely within a few weeks!
What still needs to be done with this to bring it up to scratch, Michael? I presume some more work now MBS-3708 has been completed?
Awesome, thanks a lot!
I await the next version of Picard.