Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-848

Cannot fetch cover art from amazon link contains https scheme.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 1.3.2
    • Fix Version/s: 1.4
    • Component/s: Cover Art
    • Labels:
      None
    • Environment:
      Ubuntu Linux 16.10 & 16.04
      Python 2.7.12+

      Description

      Hi.

      I'm using picard to tag my audio resources.
      When tagging musics, some releases cannot fetch cover art.
      Those are not have cover art on music brainz and using amazon cover art from registerd ASIN link.
      (One example: http://musicbrainz.org/release/e0ba3ae5-68ac-43a1-8fd0-c924c6037d33 )

      I tried debug on the fly and can see picard cannot fetch amazon data from.
      parse_amazon_url function parse amazon url. (ex: http://www.amazon.co.jp/gp/product/B00005FMYV ) and get ASIN from url.

      But it failed when parse url contains https scheme.
      Because, parse_amazon_url function uses this regex '^http://(?:www.)?(?P<host>.?)(?:\:[0-9]+)?/./(?P<asin>[0-9B][0-9A-Z]

      {9}

      )(?:[^0-9A-Z]|$)'.
      This only accept http url. So, picard should fix this regex for parse url contains https.

        Attachments

          Activity

            People

            • Assignee:
              koxel Barami
              Reporter:
              koxel Barami
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: